Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: bring back the go mod and sum files #718

Merged
merged 1 commit into from
Apr 13, 2023
Merged

build: bring back the go mod and sum files #718

merged 1 commit into from
Apr 13, 2023

Conversation

wuhuizuo
Copy link
Contributor

@wuhuizuo wuhuizuo commented Apr 11, 2023 •
edited
Loading

The dep importing issue was existed in passed years, but currently it does not exist.

What problem does this PR solve?

Issue Number: close #661

What is changed and how it works?

Check List

Tests

  • Manual test:
    • make build
    • make test
  • No code

Code changes

  • None

Side effects

  • None

Related changes

  • None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 11, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@wuhuizuo wuhuizuo force-pushed the fix/go-mod-files branch 2 times, most recently from b6ecf3b to 8658c25 Compare April 11, 2023 07:18
@wuhuizuo
build: bring back the go mod and sum files
cc80b06 
The dep importing issue was existed in passed years, but currently it does not exist.
@wuhuizuo
Copy link
Contributor Author

/cc 3pointer

@ti-chi-bot ti-chi-bot requested a review from 3pointer April 11, 2023 07:22
lance6716
lance6716 approved these changes Apr 12, 2023
View reviewed changes
Copy link
Collaborator

@lance6716 lance6716 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tidb repo does not import tidb-tools now, so the old cycle import is solved

@wuhuizuo
Copy link
Contributor Author

@3pointer @lance6716 Thanks! Could you finally approve it with comment /merge?

@lance6716
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: cc80b06

@ti-chi-bot ti-chi-bot merged commit a3f5218 into pingcap:master Apr 13, 2023
@wuhuizuo wuhuizuo deleted the fix/go-mod-files branch April 13, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 approved these changes

@GMHDBJD GMHDBJD Awaiting requested review from GMHDBJD

@Little-Wallace Little-Wallace Awaiting requested review from Little-Wallace

@3pointer 3pointer Awaiting requested review from 3pointer

Assignees
No one assigned
Labels
first-time-contributor size/L status/can-merge status/LGT1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

can't import packet
3 participants
@wuhuizuo @ti-chi-bot @lance6716