diff: increase connection limit according to number of shard tables #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennytm
reviewed
Feb 10, 2021
pkg/diff/diff.go
Outdated
Comment on lines
624
to
626
| if err := sourceRows[i].Close(); err != nil { | ||
| return nil, err | ||
| } |
There was a problem hiding this comment.
🤔 what to do with the defer rows.Close() in line 574 then
lance6716
changed the title
lance6716
changed the title
|
/run-all-tests |
|
changed the behaviour and PR description. Happy Chinese New Year |
3pointer
approved these changes
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
close #411
What is changed and how it works?
one chunk need accessing every shard tables in one upstream, and there are
CheckThreadCountsimultaneously processing chunks. Adjust connection limit to fix the worst case which needsCheckThreadCount* number of shard tables connections.Check List
Tests
Code changes
Side effects
Related changes