Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove binlogctl #266

Merged
merged 2 commits into from
Sep 9, 2019
Merged

Conversation

WangXiangUSTC
Copy link
Contributor

What problem does this PR solve?

binlogctl had already moved to https://github.com/pingcap/tidb-binlog/tree/master/binlogctl, so can remove this project in this repo.

What is changed and how it works?

delete everything about binlogctl

Copy link
Contributor

@july2993 july2993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@suzaku suzaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WangXiangUSTC WangXiangUSTC merged commit 82398b5 into pingcap:master Sep 9, 2019
@WangXiangUSTC WangXiangUSTC deleted the xiang/remove_binlogctl branch September 9, 2019 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants