Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mod #107

Merged
merged 1 commit into from
Nov 6, 2018
Merged

fix mod #107

merged 1 commit into from
Nov 6, 2018

Conversation

IANTHEREAL
Copy link
Collaborator

What problem does this PR solve?

import tidb/types/parser_driver for ast Expr

What is changed and how it works?

remove vendor and use go modules

Check List

Tests

  • Unit test
  • Integration test - https://internal.pingcap.net/jira/browse/TOOL-564
  • Manual test (add detailed scripts or steps below)
    make importer and run ./bin/importer -L info -h 10.8.143.120 -P 3308 -u root -D shard_db_01 -t 'create table shard_table_01(a int unique comment '\''[[range=1,1000]]'\'', b double, c varchar(10));' -c 1 -b 1000 -n 1000

@csuzhangxc
Copy link
Member

LGTM

1 similar comment
@july2993
Copy link
Contributor

july2993 commented Nov 6, 2018

LGTM

@IANTHEREAL IANTHEREAL merged commit 2eb189b into master Nov 6, 2018
@IANTHEREAL IANTHEREAL deleted the ian/mod branch November 6, 2018 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants