Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: update TiProxy logic and fix goroutine leak #4802

Merged
merged 4 commits into from
Dec 20, 2022
Merged

Conversation

xhebox
Copy link
Contributor

@xhebox xhebox commented Dec 12, 2022

Signed-off-by: xhe xw897002528@gmail.com

What problem does this PR solve?

Found goroutine leak in long-running tests, ref pingcap/tiproxy#149. Two things are changed:

  1. update TiProxy version to prevent leak.
  2. update TiProxy config change/health check logic to adapt the new TiProxy version.

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

Fix bug that operator may have goroutine leaks with TiProxy enabled in the long-running.

Signed-off-by: xhe <xw897002528@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 12, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • KanShiori
  • csuzhangxc

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2022

Codecov Report

Merging #4802 (48a8b37) into master (c98a97b) will increase coverage by 8.90%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4802      +/-   ##
==========================================
+ Coverage   59.78%   68.68%   +8.90%     
==========================================
  Files         223      227       +4     
  Lines       25008    27976    +2968     
==========================================
+ Hits        14951    19216    +4265     
+ Misses       8654     7341    -1313     
- Partials     1403     1419      +16     
Flag Coverage Δ
e2e 53.71% <0.00%> (?)
unittest 59.80% <0.00%> (+0.02%) ⬆️

xhebox and others added 2 commits December 15, 2022 14:23
Signed-off-by: xhe <xw897002528@gmail.com>
@csuzhangxc
Copy link
Member

/test pull-e2e-kind-serial

@xhebox
Copy link
Contributor Author

xhebox commented Dec 16, 2022

/test pull-e2e-kind-serial
/test pull-e2e-kind

@xhebox
Copy link
Contributor Author

xhebox commented Dec 16, 2022

/test pull-e2e-kind-across-kubernetes

@xhebox
Copy link
Contributor Author

xhebox commented Dec 19, 2022

/test pull-e2e-kind-serial
/test pull-e2e-kind

@csuzhangxc
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 48a8b37

@ti-chi-bot ti-chi-bot merged commit 8504e4e into pingcap:master Dec 20, 2022
@xhebox xhebox deleted the rel branch December 20, 2022 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants