Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidb: set tidb support set label min version to v6.3.0 #4724

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

glorv
Copy link
Contributor

@glorv glorv commented Sep 26, 2022

What problem does this PR solve?

What is changed and how does it work?

The least version that tidb support set server labels via HTTP is v6.3.0, so we should skip set labels before this version.

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 26, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • KanShiori
  • csuzhangxc

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@glorv
Copy link
Contributor Author

glorv commented Sep 26, 2022

/cc @KanShiori @handlerww

@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2022

Codecov Report

Merging #4724 (ca68193) into master (24554a9) will increase coverage by 7.60%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4724      +/-   ##
==========================================
+ Coverage   61.58%   69.18%   +7.60%     
==========================================
  Files         206      210       +4     
  Lines       22750    25492    +2742     
==========================================
+ Hits        14010    17637    +3627     
+ Misses       7441     6558     -883     
+ Partials     1299     1297       -2     
Flag Coverage Δ
e2e 52.76% <ø> (?)
unittest 61.56% <ø> (-0.02%) ⬇️

@KanShiori
Copy link
Collaborator

/test pull-e2e-kind-br

@KanShiori
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ca68193

@ti-chi-bot ti-chi-bot merged commit 5e8dfff into pingcap:master Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants