Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

restore: don't change TiDB config to support lightning via SQL #545

Merged
merged 1 commit into from
Jan 4, 2021

Conversation

lance6716
Copy link
Contributor

What problem does this PR solve?

after use lightning as library, init() changed TiDB's global configuration unexpected

What is changed and how it works?

try removing usage of tidbcfg

Check List

Tests

  • pass original test

Side effects

Related changes

@lance6716
Copy link
Contributor Author

cc @crazycs520

@ti-srebot
Copy link
Contributor

@breeswish, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: migrate(slack).

@glorv
Copy link
Contributor

glorv commented Jan 4, 2021

LGTM

@ti-srebot ti-srebot added the status/LGT1 One reviewer already commented LGTM (LGTM1) label Jan 4, 2021
@ti-srebot ti-srebot removed the status/LGT1 One reviewer already commented LGTM (LGTM1) label Jan 4, 2021
@ti-srebot ti-srebot added the status/LGT2 Two reviewers already commented LGTM, ready for merge (LGTM2) label Jan 4, 2021
@kennytm kennytm merged commit d89fe86 into pingcap:master Jan 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status/LGT2 Two reviewers already commented LGTM, ready for merge (LGTM2)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants