Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github.com/oleiade/reflections to v1.0.1 to avoid checksum mismatch #850

Merged
merged 5 commits into from
Feb 19, 2021

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Feb 5, 2021

See oleiade/reflections#14 for details.

@CLAassistant
Copy link

CLAassistant commented Feb 5, 2021

CLA assistant check
All committers have signed the CLA.

@baurine
Copy link
Collaborator

baurine commented Feb 6, 2021

hi @dveeden, thanks for your contribution, the CI doesn't pass, can you check it.

@breezewish
Copy link
Member

Thank you for your contribution! The CI failed due to some linter problems. I guess it is not related to your change and I will take a look.

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • breeswish

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@breezewish
Copy link
Member

I managed to fix the CI build error after cleaning up the go.sum.

@breezewish breezewish merged commit 9debd48 into pingcap:master Feb 19, 2021
@breezewish
Copy link
Member

breezewish commented Feb 19, 2021

Note: for people that facing build failures due to reflection commit change, you are likely to use GOPPROXY=direct. In order to migrate the issue, you can also try with something like:

GOPROXY=https://proxy.golang.org make

shhdgit pushed a commit to shhdgit/tidb-dashboard that referenced this pull request Feb 20, 2021
@tisonkun
Copy link

Note: for people that facing build failures due to reflection commit change, you are likely to use GOPPROXY=direct. In order to migrate the issue, you can also try with something like:

GOPROXY=https://proxy.golang.org make

Thanks. It should have saved hours of work.

breezewish added a commit that referenced this pull request Mar 12, 2021
* use cache for slow query and statements (#828)
* Optimize slow-query list (#835)
* keyviz: fix the bug that table info cannot be obtained if the database name contains special chars (#840)
* ui: remember the coarse scrolled position for statements and slow queries list (#843)
* ui: refine page change statistics (#839)
* fix slow query bug when order by other fields (#838)
* config: fix the bug that the dynamic config cannot be obtained when the PD starts later than the dashboard server (#842)
* Add placeholders for using scaffold (#844)
* ui: add more shared session expired duration options (#849)
* Fix(ui): Fix statemtent list initial loading (#846)
* Update github.com/oleiade/reflections to v1.0.1 to avoid checksum mismatch (#850)
* update package name (#857)
* keyviz: support obtaining table info with clustered index from tidb (#845)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants