Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add min height of topology canvas #804

Merged
merged 3 commits into from
Nov 24, 2020
Merged

add min height of topology canvas #804

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3f92e47
add min height and i18n
unbyte Nov 23, 2020
eba55c8
resolve comments
unbyte Nov 23, 2020
ffabb18
remove useless code
unbyte Nov 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
remove useless code
  • Loading branch information
@unbyte
unbyte committed Nov 24, 2020
commit ffabb18a5f4d901ba0de58d931ed81f3cdd431ef
2 changes: 1 addition & 1 deletion ui/lib/apps/ClusterInfo/components/StoreLocation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export default function StoreLocation() {
<StoreLocationTree
dataSource={treeData}
getMinHeight={
() => document.documentElement.clientHeight - 80 - 48 * 2 // 48 = margin of cardInner}
() => document.documentElement.clientHeight - 80 - 48 * 2 // 48 = margin of cardInner
}
/>
</AnimatedSkeleton>
Expand Down
2 changes: 1 addition & 1 deletion ui/lib/apps/ClusterInfo/components/StoreLocationTree/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ export default function StoreLocationTree({
.duration(duration)
.attr('width', divWidth)
.attr('height', Math.max(getMinHeight?.() || 0, contentHeight))
console.log(getMinHeight?.())

// update the nodes
const node = gNode.selectAll('g').data(nodes, (d: any) => d.id)

Expand Down