ui: Remove monorepo #355
Merged
ui: Remove monorepo #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Breezewish <me@breeswish.org>
Signed-off-by: Breezewish <me@breeswish.org>
Signed-off-by: Breezewish <me@breeswish.org>
Signed-off-by: Breezewish <me@breeswish.org>
Signed-off-by: Breezewish <me@breeswish.org>
baurine
reviewed
Apr 16, 2020
Comment on lines
+15
to
+33
| static newReactSpaApp = function (rootComponentAsyncLoader, targetDomId) { | ||
| const reactLifecycles = singleSpaReact({ | ||
| React, | ||
| ReactDOM, | ||
| loadRootComponent: async () => { | ||
| const component = await rootComponentAsyncLoader() | ||
| if (component.default) { | ||
| return component.default | ||
| } | ||
| return component | ||
| }, | ||
| domElementGetter: () => document.getElementById(targetDomId), | ||
| }) | ||
| return { | ||
| bootstrap: [reactLifecycles.bootstrap], | ||
| mount: [reactLifecycles.mount], | ||
| unmount: [reactLifecycles.unmount], | ||
| } | ||
| } |
baurine
reviewed
Apr 16, 2020
Comment on lines
+5
to
+6
| import { Head } from '@lib/components' | ||
| import { DateTime } from '@lib/components' |
There was a problem hiding this comment.
not a big deal, but can be combined, same as the following line 7 and 9
baurine
reviewed
Apr 16, 2020
Comment on lines
+7
to
+8
| import { Head } from '@lib/components' | ||
| import { CardTableV2 } from '@lib/components' |
baurine
reviewed
Apr 16, 2020
| import { Card, CardTableV2 } from '@lib/components' | ||
| import client from '@lib/client' | ||
| import { useClientRequest } from '@lib/utils/useClientRequest' | ||
| import DateTime from '@lib/components/DateTime' |
baurine
reviewed
Apr 16, 2020
Comment on lines
+1
to
+5
| import client from '@lib/client' | ||
| import { | ||
| LogsearchCreateTaskGroupRequest, | ||
| LogsearchSearchTarget, | ||
| } from '@pingcap-incubator/dashboard_client' | ||
| } from '@lib/client' |
baurine
reviewed
Apr 16, 2020
Comment on lines
+1
to
+2
| import client from '@lib/client' | ||
| import { LogsearchSearchTarget, LogsearchTaskGroupResponse } from '@lib/client' |
baurine
reviewed
Apr 16, 2020
Comment on lines
+1
to
+2
| import client from '@lib/client' | ||
| import { LogsearchTaskModel } from '@lib/client' |
baurine
reviewed
Apr 16, 2020
Comment on lines
+1
to
+2
| import client from '@lib/client' | ||
| import { LogsearchSearchTarget, LogsearchTaskModel } from '@lib/client' |
There was a problem hiding this comment.
yeah, I did a global search & replace, so there will be some duplicate imports..
baurine
approved these changes
Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the monorepo to make life easier.
Fix #324
Fix #280
Fix #269
Fix #170
Fix #75
Also fix:
@import '~antd/es/...in packages@umijs/hooksin packages