backend: add /logs API for searching logs
#3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deardrops
changed the title
/logs API for search logs/logs API for searching logs
baurine
reviewed
Jan 7, 2020
|
Do you mean the client should fetch logs of different components or instances individually? and sort them by time in the client? |
|
@lonng This is a POC implementation. I have sent you a formal design. |
breezewish
reviewed
Jan 14, 2020
breezewish
reviewed
Jan 14, 2020
mapleFU
reviewed
Jan 15, 2020
Deardrops
changed the title
/logs API for searching logs/logs API for searching logs
Deardrops
changed the title
/logs API for searching logs/logs API for searching logs
wjhuang2016
reviewed
Jan 20, 2020
Merged
breezewish
reviewed
Feb 9, 2020
lonng
reviewed
Feb 11, 2020
lonng
reviewed
Feb 11, 2020
pkg/apiserver/logsearch/router.go
Outdated
| StatusPort: "10080", | ||
| }, | ||
| } | ||
| taskGroupID := scheduler.addTasks(components, searchLogReq) |
There was a problem hiding this comment.
Does a single search request contain multiple tasks?
There was a problem hiding this comment.
Yes, a request will start a taskGroup, and it will start multiple tasks (one component per task).
breezewish
reviewed
Feb 13, 2020
pkg/apiserver/logsearch/models.go
Outdated
|
|
||
| type PreviewModel struct { | ||
| ID uint `json:"-" grom:"primary_key"` | ||
| TaskID string `json:"task_id" gorm:"index;type:char(36)"` |
There was a problem hiding this comment.
how about using simple auto increment int?
There was a problem hiding this comment.
It will increase code complexity, I'd keep using UUID.
Signed-off-by: Breezewish <me@breeswish.org>
Polish some code
breezewish
approved these changes
Feb 26, 2020
Closed
shhdgit
pushed a commit
to shhdgit/tidb-dashboard
that referenced
this pull request
Jan 21, 2022
shhdgit
pushed a commit
to shhdgit/tidb-dashboard
that referenced
this pull request
Jun 23, 2022
Refactor/tree diagram
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add a new API
/api/logsfor Dashboard backend.For all available APIs, please run
and visit API documents generated by swagger:
http://127.0.0.1:12333/dashboard/api/swagger/index.html
Changes: