Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: slow query and statements apps refines #1498

Merged
merged 8 commits into from
Mar 2, 2023
Merged

chore: slow query and statements apps refines #1498

merged 8 commits into from
Mar 2, 2023

Conversation

baurine
Copy link
Collaborator

@baurine baurine commented Feb 27, 2023 •
edited
Loading

What Did

  1. Make slow query list page remember the filter options again when jumping back from detail page
  2. Update wording "Get 24 results" to "24 results"
  3. Reduce the spacing between toolbar and result
  4. Support config whether do instant query
  5. Support to limit the slow query time range picker range

Preview

image

image

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 27, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • shhdgit

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@baurine baurine changed the title chore: slow query refines chore: slow query and statements apps refines Feb 27, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2023 •
edited
Loading

Codecov Report

Merging #1498 (cde5307) into master (43533b6) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1498   +/-   ##
=======================================
  Coverage   24.67%   24.67%           
=======================================
  Files         167      167           
  Lines       14972    14972           
=======================================
+ Hits         3694     3695    +1     
+ Misses      11007    11006    -1     
  Partials      271      271
Flag Coverage Δ
backend_integration 8.93% <ø> (ø)
backend_ut 27.25% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43533b6...cde5307. Read the comment docs.

@ti-chi-bot
Copy link
Member

@YiniXu9506: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@baurine
Copy link
Collaborator Author

baurine commented Mar 2, 2023

/can-merge

@ti-chi-bot ti-chi-bot merged commit 6e6505f into master Mar 2, 2023
@ti-chi-bot ti-chi-bot deleted the fix/slow_query_nav_back branch March 2, 2023 01:11
SabaPing pushed a commit to SabaPing/tidb-dashboard that referenced this pull request Apr 4, 2023
@baurine @SabaPing
chore: slow query and statements apps refines (pingcap#1498)
ba833e3
SabaPing added a commit that referenced this pull request Apr 4, 2023
@SabaPing @shhdgit
@YiniXu9506 @baurine @zeminzhou @just1900 @zhongzc @pingandb
Release v7.0.0 [skip pd_pr] (#1509)
c90c070 
* chore: adjust time range limit (#1485)

* tweak: change time range by cluster type (#1486)

      * tweak: change time range by cluster type

* fix typo

* Feat/sql index advisor (#1460)

* feat: add insight index advisor app

* chore: sync upstream master

* fix: lint

* chore: add authorization header for api req (#1490)

* chore: add authorization header for api req

* chore: bump tidb-dashboard-for-clinic-cloud to 0.0.51

* chore: refine sql advisor (#1488)

* chore: refine sql advisor

* chore: refine index advisor

* fix: lint

* refine: aysnc await usage

* Revert "upgrade etcd client (#1491)" (#1495)

* Hotifx Index Advisor (#1496)

* chore: slow query and statements apps refines (#1498)

* feat: adjust statement work for serverless clusters (#1500)

* feat: adjust statement to work for serverless cluster

* chore: bump tidb-dashboard-for-clinic-cloud to 0.0.54

* chore: rename CLINIC_UI_DASHBOARD_PATH to TARGET_VARIANT_DASHBOARD_PATH

* fix: fix navigation back miss the selected time range info

* chore: support hide the page load progress bar

* chore: bump tidb-dashboard-for-clinic-cloud to 0.0.55

* chore: slight refine

* chore: bump tidb-dashboard-for-clinic-cloud to 0.0.56

* feat: node metrics (#1501)

* add avg by for metrics query (#1503)

* update metrics chart (#1502)

* update metrics

* update version

* use fixed pnpm version to build image (#1508)

* Fixed issue #1505: Wrong disk mount directory of TiFlash (#1506)

* tweak(perf_insight): update apis & workflow (#1504)

* update version

---------

Co-authored-by: Suhaha <jklopsdfw@gmail.com>
Co-authored-by: Yini Xu <34967660+YiniXu9506@users.noreply.github.com>
Co-authored-by: Sparkle <1284531+baurine@users.noreply.github.com>
Co-authored-by: zzm <zhouzemin@pingcap.com>
Co-authored-by: Justin Huang <legendj228@gmail.com>
Co-authored-by: Zhenchi <zhongzc_arch@outlook.com>
Co-authored-by: Ping An Technology Database Team <109205475+pingandb@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YiniXu9506 YiniXu9506 YiniXu9506 approved these changes

@shhdgit shhdgit shhdgit approved these changes

Assignees
No one assigned
Labels
status/can-merge status/LGT1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@baurine @ti-chi-bot @codecov-commenter @shhdgit @YiniXu9506