Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker image support and misc. improvements #1439

Merged
merged 20 commits into from
Nov 11, 2022
Merged

Docker image support and misc. improvements #1439

merged 20 commits into from
Nov 11, 2022

Conversation

SabaPing
Copy link
Contributor

@SabaPing SabaPing commented Nov 8, 2022

  • disable always-fail ngm e2e test;
  • add docker image;
  • add descriptions for tls command-line arguments;

@SabaPing
disable always-fail ngm e2e test;
366caaf 
add docker image;
add descriptions for tls command-line arguments;
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 8, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • baurine

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2022 •
edited
Loading

Codecov Report

Merging #1439 (1598d5c) into master (b12b62e) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1439   +/-   ##
=======================================
  Coverage   26.18%   26.19%           
=======================================
  Files         202      202           
  Lines       15405    15405           
  Branches      103      103           
=======================================
+ Hits         4034     4035    +1     
+ Misses      11100    11099    -1     
  Partials      271      271
Flag Coverage Δ
backend_integration 8.97% <ø> (+0.03%) ⬆️
backend_ut 27.58% <ø> (+0.01%) ⬆️
e2e_test 62.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b12b62e...1598d5c. Read the comment docs.

baurine
baurine reviewed Nov 8, 2022
View reviewed changes
.github/workflows/test.yaml Outdated Show resolved Hide resolved
baurine
baurine reviewed Nov 8, 2022
View reviewed changes
.github/workflows/test.yaml Outdated Show resolved Hide resolved
baurine
baurine reviewed Nov 8, 2022
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
baurine
baurine reviewed Nov 9, 2022
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@SabaPing
optimize docker build cache;
883e75f 
rever CONTRIBUTING.md;
@SabaPing
optimize docker build cache;
03a9d05 
rever CONTRIBUTING.md;
baurine
baurine reviewed Nov 9, 2022
View reviewed changes
Dockerfile Show resolved Hide resolved
@baurine
Copy link
Collaborator

baurine commented Nov 10, 2022

hi @YiniXu9506 , please help have a look the e2e tests when you're free, it seems all e2e tests are failed.

@shhdgit
Copy link
Member

shhdgit commented Nov 10, 2022

hi @YiniXu9506 , please help have a look the e2e tests when you're free, it seems all e2e tests are failed.

It looks like there's some network issue with the UI assets in the docker.
image

shhdgit
shhdgit reviewed Nov 10, 2022
View reviewed changes
Makefile Show resolved Hide resolved
baurine
baurine reviewed Nov 10, 2022
View reviewed changes
docker-compose.yml Outdated Show resolved Hide resolved
@baurine
Copy link
Collaborator

baurine commented Nov 10, 2022

After adding the make package, I recommend to keep the UI=1 make usage as well for a while, some others may use UI=1 make still, for example:

image

baurine
baurine reviewed Nov 11, 2022
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
baurine
baurine reviewed Nov 11, 2022
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot merged commit 1232ae1 into pingcap:master Nov 11, 2022
@SabaPing SabaPing deleted the yifan/docker-image branch November 11, 2022 08:02
shhdgit pushed a commit to shhdgit/tidb-dashboard that referenced this pull request Dec 1, 2022
@SabaPing @shhdgit
Docker image support and misc. improvements (pingcap#1439)
5040608
shhdgit added a commit that referenced this pull request Dec 1, 2022
@shhdgit @SabaPing @baurine
Release 20221201.1 (#1446)
ea3ee69 
* Upgrade go version to 1.18; fix test in ci pipeline (#1437)

* upgrade go version to 1.18

* update github action go-version to 1.18

* try to fix ci

* Docker image support and misc. improvements (#1439)

* test: support iframe full window / full screen / open in new tab (#1442)

* support full window

* support full screen

* support show in an new tab

* tweak: add more slow query basic fields (#1445)

* tweak: add more slow query basic fields

* tweak: i18n

* Update release version

* chore: update i18n

Co-authored-by: Yifan Xu <xuyifan02@pingcap.com>
Co-authored-by: Sparkle <1284531+baurine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YiniXu9506 YiniXu9506 YiniXu9506 left review comments

@shhdgit shhdgit shhdgit approved these changes

@baurine baurine baurine approved these changes

Assignees
No one assigned
Labels
status/can-merge status/LGT1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@SabaPing @ti-chi-bot @codecov-commenter @baurine @shhdgit @YiniXu9506