fix: d3 deps conflict #1343
Merged
fix: d3 deps conflict #1343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
|
@YiniXu9506: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
shhdgit
added a commit
to shhdgit/tidb-dashboard
that referenced
this pull request
Jul 20, 2022
shhdgit
added a commit
that referenced
this pull request
Jul 21, 2022
* bump grpc (#1323) * refactor: split ui, make ui reusable (#1281) * init eslint/prettier/husky configs * fix huksy and add typescript * add tidb-dasbhoard-client package * add axios for tidb-dashboard-client * use single request parameter for tidb-dashboard-client * copy tidb-dashboard-lib from clinic-ui * rename tidb-dashboard-lib output * fix build tidb-dashboard-client fail * revert css variables * tidy dependencies * init tidb-dashboard-for-op * revert tidb-dashboard-for-op * update prettier config * add dev mode for tidb-dashboard-lib * copy files from ui * copy ui/lib to tidb-dashboard-lib * copy apps from ui to tidb-dashboard-lib * fix compile error * refine compile * fix dev for tidb-dashboard-lib * copy dashboardApp to tidb-dashboard-for-op * make tidb-dashboard-for-op pass compile * refine * export statement * export all apps * fix runtime crash * refine build * refactor slow query * extract interface for slow query * wip * fix context * make slow query work in the new arch * bring ::selection default value back * extract interface for statement app * adjust statement app * make statement interface implement slow query interface * refine tsc-alias * refine type definition * rename config field to cfg field * cancel export client from tidb-dashboard-lib * finish overview migration * migrate cluster info app * fix * migrate for top sql app * migrate keyviz app * migrate system report app * migrate search logs app * migrate instance profiling app * migrate conprof app * migrate debug api app * migrate query editor app * migrate configuration app * mirgrate user profile app * migrate diagnose app * migrate optimizer trace app * remove client in the component * refine * fix * move auth out of tidb-dashboard-lib * add event interface for UserProfile app * generate seperated models for tidb-dashboard-client and tidb-dashboard-lib * move app options and registry out of tidb-dashboard-lib * support update i18n distro when running * handle distro (part 1) * handle distro (part 2) * move publicPathPrefix out of tidb-dashboard-lib * rename basePath to apiPathBase * slight refine * remove sentry * refine client * refine build for tidb-dashboard-for-op * refine swagger build scripts * ignore prettier auto generated api files * ignore prettier generated distro string res * support skip watch api * refine load env * remove compat.js * migrate diagnose report app * TiDB Dashboard For Cloud variant (#1286) * tidb-dashboard-for-cloud * refine * listen hash change to switch apps * fix listen hash change * fix undefined ctx!.cfg.apiPathBase * disable export for tidb-dashbaord-for-cloud * update output file name * update package version * rename tidb-dashboard-for-cloud to tidb-dashboard-for-dbaas * update version * add html to test cdn * add README and update version * update README and version * update index.html * add iframe case for tidb-dashboard-for-dbaas * refine iframe test * refine * track route change for tidb-dashboard-for-dbaas * update startDashboard parameters and update version * fix can't modify statement/keyviz settings * refine watch * tidb-dashboard-for-dbaas-0.0.7 * update backend api url for test * refine update html files * move ngm from apps to components * listen routes change for all apps * expose topsql for tidb-dashboard-for-dbaas * add topsql entry * update dashboardApp entry file * revert listen tidb-dashboard-lib changes * output to dist instead of build for tidb-dashboard-for-op * fix distro in dev mode * refine wording * fix envFile and bump tidb-dashboard-for-dbaas 0.0.9 * migrate cypress (#1329) * copy cypress folder * fix start_tiup wait_tiup scripts path * refine build * update README for cypress * update Makefile and CI/CD * fix ci * fix style * fix cypress cache * test fix cypress cache for ci * test * revert cypress install * test * revert test * revert comments * move workflows back * fix: make main content area responsed for sider collapsing reason: not matched use-spring version * refine build * fix font-size * fix distro * fix broken css, make `margin-left: -48px` work again reason: css order * update README and docs * feat(ui): support metrics plan (#1331) * add metrics on overview page * add remaining metrics on overview page * update crosshair * adjust metrics panel layouts * update layout * update layout * add more tidb metrics panel on overview page * 0.0.10-beta for tidb-dashboard-for-dbaas * export overview for tidb-dashboard-for-dbaas * 0.0.11-beta for tidb-dashboard-for-dbaas * add overview link Co-authored-by: baurine <2008.hbl@gmail.com> Co-authored-by: Yini Xu <34967660+YiniXu9506@users.noreply.github.com> * refactor(ui): cleanup after refactoring UI (#1334) * remove original ui folder * rename ui-new to ui * ui: refine ui build script (#1335) * merge all models into a file * fix problem trigger tidb-dashboard-lib rebuild too many times * ui code refines (#1336) * fix broken css for tidb-dashboard-for-dbaas * fix react-hooks/exhaustive-deps warning * remove un-used comments * fix tidb-dashboard-for-dbaas root font-size * Refine metrics (#1338) * fix(metrics): orphan data points caused by `null` value * feat(metrics-chart): add nullValue config * fix: d3 deps conflict (#1343) * feat: extract metrics from overview app (#1337) * chore: extract metrics from overview app * update metrics app on dbaas * update side menu and metrics panel ui * resolve comments * chore: update metrics query * chore: add new metrics * chore: update promql rate_interval * remove useless file * remove un-used apis * align the chart and toolbar Co-authored-by: Suhaha <jklopsdfw@gmail.com> Co-authored-by: baurine <2008.hbl@gmail.com> * fix: Unnecessary render (#1349) * fix: Unnecessary render * chore: use debounce * Feat visual plan (#1347) * Dashboard: support parse visual plan (#1227) * init * fix * add test * fix * use binary_plan (#1284) * Visual Plan (#1285) * feat: add visual plan for slowquery and statement * make visual plan as a independent module * update without minimap * update minimap * update * update * update minimap on brush and zoom * fix: restriction of minimap brush * refine minimap * update variable declaration * update minimap and mainchart * move minimap translate to minimap * combine some interface * add node detail drawer * move brush svg into minimap * chore: rename * chore: rename * fix: memorize node margin * chore: update node detail drawer * add thumbnail for tree digram * chore: update node detail * fix ci Co-authored-by: Suhaha <jklopsdfw@gmail.com> * fix: empty binary_plan * Analyze visual plan (#1320) * use protojson * fix * format json * set concurrency * init Duration * add diagnosticOperator * fix * fix * fix * Update provider.go * fix * fix * update ui * fix * fix go-lint * fix git diff --exit-code * fix git diff --exit-code * fix * add TestUseComparisonOperator * to circumvent golint v1.45.0 * fix stirngs.Cut * fix stirngs.Cut * fix: vp pseudo (#1321) * fix * fix * Support multi tree (#1324) * chore: support multi trees * fix: udpate multi tree * fix: add single tree * update multi trees * update multi trees * update multi trees * update multi trees * refactor: default node & link * refine: better fps * api: test * api: test * update node details * refine: minimap * style: update * refine: use memo to cache the component * chore: wrong usage * update thumbnail * update thumbnail * resolve comments * update variable get * chore: update thumbnail bound * update structure * fix ci * refine ts Co-authored-by: Suhaha <jklopsdfw@gmail.com> * add a new interface and fix some field parsing issues (#1325) * fix some field parsing issues * fix * fix * fix * fix go-lint * fix node detail label * add vp to statement detail page (#1326) * fix: compatibility on safari (#1327) * style: refine ui (#1332) * style: refine ui * update adjust position * update modal height * ci: fix lint * add unit tests (#1328) * add unit tests * fix * upgrade go.mod * refine visual plan (#1339) * refine visual plan * update translations * ci: fix lint * update i18n * ci: fix lint * use role tag (#1341) * use role tag * fix * fix * adjust execution plan UI position (#1342) * adjust execution plan UI position * chore: fix Execution plan tab * ci: fix lint * delete debug msg (#1345) * Add telemetry for vp (#1340) * refine visual plan * update translations * ci: fix lint * add telemetry for visual plan * update telemetry * ci: fix lint * ci: fix lint * delete: yarn.lock * fix unit test (#1351) Co-authored-by: Qiμ$hiЯuí <39378935+srstack@users.noreply.github.com> Co-authored-by: Suhaha <jklopsdfw@gmail.com> * Refine metrics plan (#1352) * chore: add color for specific sql type * update labels * refactor: customize series color * fix: database time series color * fix: database time series color * update query * refine: colors * update: colors Co-authored-by: Suhaha <jklopsdfw@gmail.com> * Update release version * update query name (#1354) * fix: fmt * fix null value (#1355) * fix null value * remove useless file Co-authored-by: Zhenchi <zhongzc_arch@outlook.com> Co-authored-by: Sparkle <1284531+baurine@users.noreply.github.com> Co-authored-by: Yini Xu <34967660+YiniXu9506@users.noreply.github.com> Co-authored-by: baurine <2008.hbl@gmail.com> Co-authored-by: Qiμ$hiЯuí <39378935+srstack@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed the d3 deps conflict in some cases.