Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine conprof #1102

Merged
merged 17 commits into from
Dec 29, 2021
Merged

Refine conprof #1102

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
fdc54ab
update wording
baurine Dec 16, 2021
58e6a3a
not check prom any more
baurine Dec 16, 2021
482e57f
replace time range component
baurine Dec 16, 2021
e9cf8cc
i18n
baurine Dec 16, 2021
7ee12f7
support view profile by diffrent ways
baurine Dec 17, 2021
fdb06b3
Merge remote-tracking branch 'origin/master' into HEAD
baurine Dec 17, 2021
702c73d
extract ActionsButton
baurine Dec 20, 2021
8a21614
change download data format
baurine Dec 20, 2021
07e8457
refine
baurine Dec 20, 2021
3b03fdb
comments
baurine Dec 20, 2021
977780f
Revert "comments"
baurine Dec 20, 2021
3faa4e7
fix view cpu profile fail
baurine Dec 20, 2021
7603865
Merge remote-tracking branch 'origin/master' into refine-conprof
baurine Dec 24, 2021
cbc380a
update state
baurine Dec 24, 2021
f6842cb
hide action button if disable
baurine Dec 24, 2021
39bd50b
Merge remote-tracking branch 'origin/master' into refine-conprof
baurine Dec 29, 2021
6333063
address feedback
baurine Dec 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
hide action button if disable
  • Loading branch information
@baurine
baurine committed Dec 24, 2021
commit f6842cbf301d2ed8ab4601cdd0863b9dbdb6ea8d
16 changes: 6 additions & 10 deletions ui/lib/components/ActionsButton/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,15 @@ export default function ActionsButton({
throw new Error('actions should at least have one action')
}

if (disabled) {
return null
}

// actions.length > 0
const mainAction = actions[0]
if (actions.length === 1) {
return (
<Button
disabled={disabled}
onClick={() => onClick(mainAction.key)}
style={{ width: 150 }}
>
<Button onClick={() => onClick(mainAction.key)} style={{ width: 150 }}>
{mainAction.text}
</Button>
)
Expand All @@ -47,11 +47,7 @@ export default function ActionsButton({
</Menu>
)
return (
<Dropdown.Button
disabled={disabled}
overlay={menu}
onClick={() => onClick(mainAction.key)}
>
<Dropdown.Button overlay={menu} onClick={() => onClick(mainAction.key)}>
{mainAction.text}
</Dropdown.Button>
)
Expand Down