Add integration test #1083

shhdgit · 2021-12-05T14:56:54Z

Including:

Integration test
Compatibility test
CI

ti-chi-bot · 2021-12-05T14:56:55Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

baurine

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

breezewish

Cool!

Makefile

breezewish · 2021-12-06T01:53:16Z

Makefile

+test: unit_test integration_test
+
+unit_test:
+	$(GOTEST) $$(go list ./... | grep -v $(INTEGRATION_TEST_PACKAGES))


There may be another way to do this: you can use build tags to mark different kind of test packages!

Build tags seems to have some cons in static analysis: errors, code completion, etc.

How about separate different kind of tests by folder or env variables?
https://peter.bourgon.org/blog/2021/04/02/dont-use-build-tags-for-integration-tests.html

tests/run.sh

tests/download_tools.sh

.github/workflows/test.yaml

…into test/integration

shhdgit · 2021-12-20T03:19:19Z

go.mod

@@ -33,8 +33,9 @@ require (
 	github.com/pingcap/kvproto v0.0.0-20200411081810-b85805c9476c
 	github.com/pingcap/log v0.0.0-20210906054005-afc726e70354
 	github.com/rs/cors v1.7.0
+	github.com/shhdgit/testfixtures/v3 v3.6.2-0.20211219171712-c4f264d673d3


Need to adapt tidb checksum logic, I'll create a pr to upstream later

shhdgit · 2021-12-20T03:26:17Z

tests/util/dump/dump.go

@@ -0,0 +1,48 @@
+// Copyright 2021 PingCAP, Inc. Licensed under Apache-2.0.


Use testfixtures to dump yaml helps us easier to modify data.

codecov-commenter · 2021-12-20T08:03:08Z

Codecov Report

❗ No coverage uploaded for pull request base (master@26502cc). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1083   +/-   ##
=========================================
  Coverage          ?   22.52%           
=========================================
  Files             ?      106           
  Lines             ?     9946           
  Branches          ?        0           
=========================================
  Hits              ?     2240           
  Misses            ?     7554           
  Partials          ?      152

Flag	Coverage Δ
be_integration_test_latest	`7.05% <0.00%> (?)`
be_integration_test_v4.0.1	`7.05% <0.00%> (?)`
be_unit_test	`23.46% <0.00%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26502cc...8817949. Read the comment docs.

This reverts commit 9404f95.

baurine

lgtm

YiniXu9506

LGTM

ti-chi-bot · 2021-12-27T08:41:50Z

@YiniXu9506: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

* Revert "Release v2021.12.06.1 (#1084)" This reverts commit bcc43a0. * Compitable with different TiDB versions for conprof and non-root-login features (#1047) * make conprof independent * check feature enable * add check feature enable middleware * hide menu if feature is not enabled * refactor non root login switch by new design * i18n * yarn fmt * renaming * adjust fe code * refine * remove unused log * build(deps): bump ws from 5.2.2 to 5.2.3 in /ui (#1055) * CICD: Update the release pipeline for recent PD format policies (#1054) * fix i18n wording (#1056) * Refactor: Change util module to util package (#1052) * Refactor: Fix godot incorrectly add dot suffix to annotations (#1059) * lint: Add goheader for copyright lints (#1062) * Refactor: Migrate to use the `rest` package in util/ (#1060) * fix(*): globally delete/update data by GORM (#1065) * ui: bump dependencies (#1066) * refactor: Switch to use ziputil, netutil, reflectutil and fileswap (#1067) * Fix request header being pinned after pd profiling (#1069) * Integrate speedscope (#1064) * fix potential panic when GetPDInstances (#1075) Signed-off-by: crazycs <chen.two.cs@gmail.com> * Refactor: a new httpclient (#1073) * Refactor: Switch to use util/distro in all places (#1078) * chore: support import relative file URL (#1082) * Refactor: Move tools into a standalone module (#1079) * Fix script to embed the ui (#1088) * Fix script to embed the ui * Hack write_strings * Refactor feature flag to support more modules (#1057) * Drop sysutil dependency (#1093) * chore: add graph generation (#1085) * Refactor: Add TopologyProvider (#1098) * esbuild: i18n + dep (#1101) * script: Add a script to generate version matrix (#1104) * distro: support dynamic config (#1094) * chore: support multiple profiling types (#1095) * fix(distro): check distro_strings.json fmt by prettier (#1106) * script: fix generate assets (#1107) * Add integration test (#1083) * debug_api: Switch to use the new util (#1103) * refactor(ui): auto refresh button (#1105) * refactor(ui): auto refresh button * chore: update translation * fix: remain seconds * refine: refresh button * fix: onRefresh * fix: auto refresh * fix: continue tick * chore: add some comments * tweak: remaining refresh seconds * chore: clean code Co-authored-by: Wenxuan <breezewish@pingcap.com> * ui: refine conprof (#1102) * update wording * not check prom any more * replace time range component * i18n * support view profile by diffrent ways * extract ActionsButton * change download data format * refine * comments * Revert "comments" This reverts commit 3b03fdb. * fix view cpu profile fail * update state * hide action button if disable * address feedback * update release-version * sync with master Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Wenxuan <breezewish@pingcap.com> Co-authored-by: Suhaha <jklopsdfw@gmail.com> Co-authored-by: Yini Xu <34967660+YiniXu9506@users.noreply.github.com> Co-authored-by: crazycs <crazycs520@gmail.com>

shhdgit added 4 commits December 2, 2021 00:03

test: init integration

64bee06

test: integration init

e354632

test(integration): slowquery init

59de412

test(*): refine tests scripts

886a2fb

shhdgit force-pushed the test/integration branch 2 times, most recently from 5757df3 to 7346e7d Compare December 5, 2021 15:02

test(slow_query): add db session

4a98ebc

shhdgit force-pushed the test/integration branch from 7346e7d to 4a98ebc Compare December 5, 2021 16:19

Merge branch 'master' into test/integration

ee8a5e9

shhdgit marked this pull request as ready for review December 5, 2021 16:23

breezewish reviewed Dec 6, 2021

View reviewed changes

.github/workflows/test.yaml Outdated Show resolved Hide resolved

shhdgit added 2 commits December 6, 2021 16:14

test: refine test scripts

95833fe

Merge branch 'test/integration' of github.com:shhdgit/tidb-dashboard …

8f52c9d

…into test/integration

shhdgit force-pushed the test/integration branch from 45f64fd to 8f52c9d Compare December 6, 2021 08:35

shhdgit added 3 commits December 6, 2021 16:35

Merge branch 'master' into test/integration

ba7c7bb

test: update bin path

4712414

test: echo profile

074c180

shhdgit force-pushed the test/integration branch from ba90efe to 074c180 Compare December 6, 2021 09:37

shhdgit added 2 commits December 6, 2021 17:47

test: update source configs

7fb34c0

test: update integration log path

5c15f49

shhdgit force-pushed the test/integration branch from ff6e46c to 5c15f49 Compare December 6, 2021 09:54

shhdgit added 2 commits December 6, 2021 18:07

test: echo config path

9cc9b04

test: update tiup setup

c51bc38

shhdgit force-pushed the test/integration branch from df8db2e to c51bc38 Compare December 6, 2021 10:43

test: update tiup usage

bd7eca7

shhdgit force-pushed the test/integration branch from 73d76fc to bd7eca7 Compare December 7, 2021 03:58

test: temp disable diagnose integration test

f95f499

ti-chi-bot added the needs-rebase label Dec 8, 2021

test: add prev stmt search test

c7af711

shhdgit requested a review from breezewish December 20, 2021 03:10

shhdgit commented Dec 20, 2021

View reviewed changes

shhdgit added 5 commits December 20, 2021 11:29

tweak: close sys schema cache

38d3dac

chore: rename TestCompatibilitySuite

c611683

tweak: split create table workflow for local tests

67e33ca

tweak: makefile phony definition

dd1d515

test: code coverage

7aef798

shhdgit force-pushed the test/integration branch 3 times, most recently from ba91d85 to 2e05a4d Compare December 20, 2021 07:55

test: code coverage

5d43c2d

shhdgit force-pushed the test/integration branch from 2e05a4d to 5d43c2d Compare December 20, 2021 08:00

test: coverage flags

27d2cfb

shhdgit force-pushed the test/integration branch from 4001c70 to 27d2cfb Compare December 20, 2021 08:09

shhdgit added 4 commits December 20, 2021 16:16

chore: comments

f1d440a

chore: add badge to readme

9404f95

Revert "chore: add badge to readme"

b57f6c7

This reverts commit 9404f95.

chore: rename coverage flag

8817949

breezewish assigned baurine Dec 21, 2021

baurine approved these changes Dec 27, 2021

View reviewed changes

ti-chi-bot added the status/LGT1 label Dec 27, 2021

YiniXu9506 approved these changes Dec 27, 2021

View reviewed changes

breezewish merged commit 037bc50 into pingcap:master Dec 27, 2021

breezewish mentioned this pull request Dec 27, 2021

chore: add e2e test #1109

Merged

baurine pushed a commit to baurine/tidb-dashboard that referenced this pull request Dec 30, 2021

Add integration test (pingcap#1083)

14f6a34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add integration test #1083

Add integration test #1083

shhdgit commented Dec 5, 2021 •

edited

Loading

ti-chi-bot commented Dec 5, 2021 •

edited

Loading

breezewish left a comment

breezewish Dec 6, 2021

shhdgit Dec 6, 2021

shhdgit Dec 20, 2021 •

edited

Loading

shhdgit Dec 20, 2021 •

edited

Loading

codecov-commenter commented Dec 20, 2021 •

edited

Loading

baurine left a comment

YiniXu9506 left a comment

ti-chi-bot commented Dec 27, 2021

		@@ -0,0 +1,48 @@
		// Copyright 2021 PingCAP, Inc. Licensed under Apache-2.0.

Add integration test #1083

Add integration test #1083

Conversation

shhdgit commented Dec 5, 2021 • edited Loading

ti-chi-bot commented Dec 5, 2021 • edited Loading

breezewish left a comment

Choose a reason for hiding this comment

breezewish Dec 6, 2021

Choose a reason for hiding this comment

shhdgit Dec 6, 2021

Choose a reason for hiding this comment

shhdgit Dec 20, 2021 • edited Loading

Choose a reason for hiding this comment

shhdgit Dec 20, 2021 • edited Loading

Choose a reason for hiding this comment

codecov-commenter commented Dec 20, 2021 • edited Loading

Codecov Report

baurine left a comment

Choose a reason for hiding this comment

YiniXu9506 left a comment

Choose a reason for hiding this comment

ti-chi-bot commented Dec 27, 2021

shhdgit commented Dec 5, 2021 •

edited

Loading

ti-chi-bot commented Dec 5, 2021 •

edited

Loading

shhdgit Dec 20, 2021 •

edited

Loading

shhdgit Dec 20, 2021 •

edited

Loading

codecov-commenter commented Dec 20, 2021 •

edited

Loading