Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store profiling files in temp-dir instead of /tmp #1557

Open
hihihuhu opened this issue Jul 6, 2023 · 0 comments
Open

store profiling files in temp-dir instead of /tmp #1557

hihihuhu opened this issue Jul 6, 2023 · 0 comments

Comments

@hihihuhu
Copy link

hihihuhu commented Jul 6, 2023

Feature Request

Is your feature request related to a problem? Please describe:

currently the profiling files are stored in /tmp folder https://github.com/pingcap/tidb-dashboard/blob/v2023.07.05.1/pkg/apiserver/profiling/pprof.go#L61, which is cleared when pod restarts

Describe the feature you'd like:

because there is a temp-dir config, it makes more sense to store profiling files in that path as well, which is already backed by ebs in tidb-operator

Describe alternatives you've considered:

mount an ebs for /tmp in tidb-operator

Teachability, Documentation, Adoption, Migration Strategy:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant