Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pump/storge: Measure time taken to write to disk, to rotate and fsync #830

Merged
merged 1 commit into from
Nov 25, 2019
Merged

pump/storge: Measure time taken to write to disk, to rotate and fsync #830

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 23 additions & 8 deletions pump/storage/vlog.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import (
"strings"
"sync"
"sync/atomic"
"time"

"github.com/ngaut/log"
"github.com/pingcap/errors"
Expand Down Expand Up @@ -303,19 +304,37 @@ func (vlog *valueLog) write(reqs []*request) error {

var bufReqs []*request

rotate := func() error {
err := curFile.finalize()
if err != nil {
return errors.Annotatef(err, "finalize file %s failed", curFile.path)
}

id := atomic.AddUint32(&vlog.maxFid, 1)
curFile, err = vlog.createLogFile(id)
if err != nil {
return errors.Annotatef(err, "create file id %d failed", id)
}
return nil
}

toDisk := func() error {
writeT0 := time.Now()
n, err := curFile.fd.Write(vlog.buf.Bytes())
atomic.AddInt64(&vlog.writableLogOffset, int64(n))

if err != nil {
return errors.Annotatef(err, "unable to write to log file: %s", curFile.path)
}
if vlog.sync {
fsyncT0 := time.Now()
err = curFile.fdatasync()
writeBinlogTimeHistogram.WithLabelValues("fsync").Observe(time.Since(fsyncT0).Seconds())
if err != nil {
return errors.Annotatef(err, "fdatasync file %s failed", curFile.path)
}
}
writeBinlogTimeHistogram.WithLabelValues("to_disk").Observe(time.Since(writeT0).Seconds())

for _, req := range bufReqs {
curFile.updateMaxTS(req.ts())
Expand All @@ -325,15 +344,11 @@ func (vlog *valueLog) write(reqs []*request) error {

// rotate file
if vlog.writableOffset() > vlog.opt.ValueLogFileSize {
err := curFile.finalize()
if err != nil {
return errors.Annotatef(err, "finalize file %s failed", curFile.path)
}

id := atomic.AddUint32(&vlog.maxFid, 1)
curFile, err = vlog.createLogFile(id)
rotateT0 := time.Now()
err := rotate()
writeBinlogTimeHistogram.WithLabelValues("rotate").Observe(time.Since(rotateT0).Seconds())
if err != nil {
return errors.Annotatef(err, "create file id %d failed", id)
return err
}
}
return nil
Expand Down