drainer: bugfix, handle "missing column" when a column is getting dropped #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-integration-tests |
2 similar comments
|
/run-integration-tests |
|
/run-integration-tests |
suzaku
force-pushed
the
test-drop-column
branch
from
df35218
to
4c2d821
Compare
|
/run-integration-tests |
|
/run-unit-tests |
|
LGTM now |
suzaku
force-pushed
the
test-drop-column
branch
from
c1b01d9
to
867b525
Compare
suzaku
changed the title
suzaku
force-pushed
the
test-drop-column
branch
from
280596c
to
8cc56d0
Compare
|
/run-all-tests |
3 similar comments
|
/run-all-tests |
|
/run-all-tests |
|
/run-all-tests |
suzaku
force-pushed
the
test-drop-column
branch
from
64bee3d
to
d260115
Compare
|
/run-all-tests |
|
/run-unit-tests |
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
suzaku
force-pushed
the
test-drop-column
branch
from
99c6ed1
to
41e7386
Compare
|
/run-all-tests |
|
@suzaku pls fix the conflicts. |
suzaku
added
status/PTAL
type/bug
july2993
reviewed
Nov 21, 2019
|
LGTM |
WangXiangUSTC
approved these changes
Nov 21, 2019
|
need to add release note, and update upgrade document(may not compatible with old tidb?) |
|
|
/run-cherry-picker |
|
cherry pick to release-2.1 failed |
|
cherry pick to release-3.0 failed |
suzaku
added a commit
to suzaku/tidb-binlog
that referenced
this pull request
Nov 21, 2019
suzaku
added a commit
to suzaku/tidb-binlog
that referenced
this pull request
Nov 21, 2019
suzaku
added a commit
to suzaku/tidb-binlog
that referenced
this pull request
Nov 21, 2019
suzaku
added a commit
to suzaku/tidb-binlog
that referenced
this pull request
Nov 21, 2019
suzaku
added a commit
to suzaku/tidb-binlog
that referenced
this pull request
Nov 21, 2019
suzaku
added a commit
to suzaku/tidb-binlog
that referenced
this pull request
Nov 22, 2019
suzaku
added a commit
to suzaku/tidb-binlog
that referenced
this pull request
Nov 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
DML binlogs may be wrong if there's a concurrent
drop columnDDL running.The column being dropped may be missing before the corresponding DDL binlog reached drainer, because TiDB stops sending the dropped column starting from the DeleteOnly state.
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes