Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage.go: Make query tikv for ddl too (#757) #761

Merged
merged 3 commits into from
Oct 10, 2019
Merged

storage.go: Make query tikv for ddl too (#757) #761

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a620018
storage.go: Make query tikv for ddl too (#757)
july2993 Sep 30, 2019
5492bb0
refine log
july2993 Oct 10, 2019
4057e30
Update pump/storage/storage.go
july2993 Oct 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refine log
  • Loading branch information
@july2993
july2993 committed Oct 10, 2019
commit 5492bb05e251d1609d4079d7056c6cde1dc88188
6 changes: 4 additions & 2 deletions pump/storage/storage.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,7 +424,8 @@ func (a *Append) resolve(startTS int64) bool {

req := a.writeBinlog(cbinlog)
if req.err != nil {
log.Error(req.err)
log.Errorf("write missing committed binlog failed: %+v, start ts: %d commit ts: %d isDDL: %v",
req.err, startTS, status.CommitTS(), pbinlog.GetDdlJobId() > 0)
return false
}

Expand All @@ -439,7 +440,8 @@ func (a *Append) resolve(startTS int64) bool {

err = a.metadata.Put(encodeTSKey(req.ts()), pointer, nil)
if err != nil {
log.Error(err)
log.Errorf("put missing committed binlog into metadata failed: %+v, start ts: %d commit ts: %d isDDL: %v",
req.err, startTS, status.CommitTS(), pbinlog.GetDdlJobId() > 0)
july2993 marked this conversation as resolved.
Show resolved Hide resolved
return false
}
}
Expand Down