Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pump.Storage: fix possible panic if start ts is greater than max commit ts when pull binlog #758

Merged
merged 6 commits into from
Sep 30, 2019
Merged

pump.Storage: fix possible panic if start ts is greater than max commit ts when pull binlog #758

merged 6 commits into from
Sep 30, 2019

Commits on Sep 30, 2019

  1. don't search leveldb when last ts is greater than pump's max commit ts

    @WangXiangUSTC
    WangXiangUSTC committed Sep 30, 2019
    Configuration menu
    Copy the full SHA
    728af9c View commit details
    Browse the repository at this point in the history

  2. fix log

    @WangXiangUSTC
    WangXiangUSTC committed Sep 30, 2019
    Configuration menu
    Copy the full SHA
    d45b01e View commit details
    Browse the repository at this point in the history

  3. Update pump/storage/sorter.go 

    Co-Authored-By: Ian <ArGregoryIan@gmail.com>
    @WangXiangUSTC @IANTHEREAL
    WangXiangUSTC and IANTHEREAL authored Sep 30, 2019
    Configuration menu
    Copy the full SHA
    c48eb25 View commit details
    Browse the repository at this point in the history

  4. address comment

    @WangXiangUSTC
    WangXiangUSTC committed Sep 30, 2019
    Configuration menu
    Copy the full SHA
    a289573 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'xiang/fix_leveldb_panic' of https://github.com/pingcap/… 

    …tidb-binlog into xiang/fix_leveldb_panic
    @WangXiangUSTC
    WangXiangUSTC committed Sep 30, 2019
    Configuration menu
    Copy the full SHA
    c542d5d View commit details
    Browse the repository at this point in the history

  6. reduce sleep time and add comment

    @WangXiangUSTC
    WangXiangUSTC committed Sep 30, 2019
    Configuration menu
    Copy the full SHA
    c3b595f View commit details
    Browse the repository at this point in the history