-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drainer: support load table infos to save memory and add gc safepoint update #1233
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
172b1e2
cherry-pick and resolve conflicts
lichunzhu c9e9b38
fix
lichunzhu c045587
fix
lichunzhu 7994da2
Merge branch 'master' into fixLoadTableInfo2
lichunzhu fcd27dc
address comment
lichunzhu 6367f58
Merge branch 'fixLoadTableInfo2' of github.com:lichunzhu/tidb-binlog …
lichunzhu 19e727c
address comment
lichunzhu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
package drainer | ||
|
||
import ( | ||
"context" | ||
"fmt" | ||
"time" | ||
|
||
"github.com/pingcap/log" | ||
"github.com/pingcap/tidb-binlog/drainer/checkpoint" | ||
pd "github.com/tikv/pd/client" | ||
"go.uber.org/zap" | ||
) | ||
|
||
const ( | ||
drainerServiceSafePointPrefix = "drainer" | ||
defaultDrainerGCSafePointTTL = 5 * 60 | ||
) | ||
|
||
func updateServiceSafePoint(ctx context.Context, pdClient pd.Client, cpt checkpoint.CheckPoint, ttl int64) { | ||
updateInterval := time.Duration(ttl/2) * time.Second | ||
tick := time.NewTicker(updateInterval) | ||
defer tick.Stop() | ||
dumplingServiceSafePointID := fmt.Sprintf("%s_%d", drainerServiceSafePointPrefix, time.Now().UnixNano()) | ||
log.Info("generate drainer gc safePoint id", zap.String("id", dumplingServiceSafePointID)) | ||
|
||
for { | ||
snapshotTS := uint64(cpt.TS()) | ||
log.Debug("update PD safePoint limit with ttl", | ||
zap.Uint64("safePoint", snapshotTS), | ||
zap.Int64("ttl", ttl)) | ||
for retryCnt := 0; retryCnt <= 10; retryCnt++ { | ||
_, err := pdClient.UpdateServiceGCSafePoint(ctx, dumplingServiceSafePointID, ttl, snapshotTS) | ||
if err == nil { | ||
break | ||
} | ||
log.Debug("update PD safePoint failed", zap.Error(err), zap.Int("retryTime", retryCnt)) | ||
select { | ||
case <-ctx.Done(): | ||
return | ||
case <-time.After(time.Second): | ||
} | ||
} | ||
select { | ||
case <-ctx.Done(): | ||
return | ||
case <-tick.C: | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tick.Stop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed in 19e727c