Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

relay log for oracle #1104

Merged
merged 4 commits into from
Dec 27, 2021
Merged

relay log for oracle #1104

merged 4 commits into from
Dec 27, 2021

Conversation

cartersz
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

What is changed and how it works?

supporting relay log feature

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update the tidb-ansible repository
  • Need to be included in the release note

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 23, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • glorv
  • lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

lichunzhu
lichunzhu reviewed Dec 24, 2021
View reviewed changes
drainer/relay.go Outdated Show resolved Hide resolved
drainer/relay_test.go Outdated Show resolved Hide resolved
pkg/loader/translate.go Outdated Show resolved Hide resolved
pkg/loader/translate.go Outdated Show resolved Hide resolved
pkg/loader/translate.go Outdated Show resolved Hide resolved
drainer/relay.go Outdated Show resolved Hide resolved
drainer/relay_test.go Show resolved Hide resolved
@cartersz
Copy link
Contributor Author

/run-all-tests

@lichunzhu
Copy link
Contributor

/run-all-tests

@lichunzhu lichunzhu closed this Dec 27, 2021
@lichunzhu lichunzhu reopened this Dec 27, 2021
lichunzhu
lichunzhu reviewed Dec 27, 2021
View reviewed changes
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM
@glorv PTAL

drainer/relay.go Outdated Show resolved Hide resolved
@cartersz
Copy link
Contributor Author

/run-all-tests

lichunzhu
lichunzhu approved these changes Dec 27, 2021
View reviewed changes
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lichunzhu
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 297fd73

@ti-chi-bot ti-chi-bot merged commit 3330cb7 into pingcap:master Dec 27, 2021
@cartersz cartersz mentioned this pull request Dec 27, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glorv glorv glorv approved these changes

@lichunzhu lichunzhu lichunzhu approved these changes

Assignees
No one assigned
Labels
size/XL status/can-merge status/LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cartersz @ti-chi-bot @lichunzhu @glorv