Skip to content
This repository has been archived by the owner on Jun 24, 2021. It is now read-only.

Update OS version requirements #663

Merged
merged 4 commits into from
Jan 18, 2019
Merged

Update OS version requirements #663

merged 4 commits into from
Jan 18, 2019

Conversation

liubo0127
Copy link
Contributor

@overvenus
Copy link
Member

Better to test if the os can run #660 successfully.

@LinuxGit
Copy link
Contributor

LinuxGit commented Jan 12, 2019

|string can be omitted. It's better to check the ansible_distribution_version variable on RHEL 7.

Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a centos 7.3 docker contiainer runs on a centos 7.2 host, this container still does not support EPOLLEXCLUSIVE.

@LinuxGit
Copy link
Contributor

@overvenus tidb-ansible's docker deployment method is deprecated and removed from docs.
@liubo0127 @superlzs0476 If checking os version is not accurate,we should use overvenus's binary to check it.

@liubo0127
Copy link
Contributor Author

@overvenus @LinuxGit @superlzs0476 Done, PTAL

Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please attach epollexclusive's source code for future maintainance.
Also I suggest to reduce the binary by passing option "-Os" to "Optimize for size" and use strip to remove debug info.

@liubo0127
Copy link
Contributor Author

liubo0127 commented Jan 17, 2019

Here is the programme that checks the EPOLLEXCLUSIVE.

/*
 *
 * Copyright 2017 gRPC authors.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 *
 */

#include <errno.h>
#include <sys/eventfd.h>
#include <sys/epoll.h>
#include <unistd.h>
#include <stdio.h>

#ifndef EPOLLEXCLUSIVE
#define EPOLLEXCLUSIVE (1 << 28)
#endif

/* This polling engine is only relevant on linux kernels supporting epoll() */
bool grpc_is_epollexclusive_available(void) {
  static bool logged_why_not = false;

  int fd = epoll_create1(EPOLL_CLOEXEC);
  if (fd < 0) {
    if (!logged_why_not) {
      printf(
              "epoll_create1 failed with error: %d. Not using epollex polling "
              "engine.",
              fd);
      logged_why_not = true;
    }
    return false;
  }
  int evfd = eventfd(0, EFD_NONBLOCK | EFD_CLOEXEC);
  if (evfd < 0) {
    if (!logged_why_not) {
      printf(
              "eventfd failed with error: %d. Not using epollex polling "
              "engine.",
              fd);
      logged_why_not = true;
    }
    close(fd);
    return false;
  }
  struct epoll_event ev;
  /* choose events that should cause an error on
     EPOLLEXCLUSIVE enabled kernels - specifically the combination of
     EPOLLONESHOT and EPOLLEXCLUSIVE */
  ev.events = (uint32_t)(EPOLLET | EPOLLIN | EPOLLEXCLUSIVE | EPOLLONESHOT);
  ev.data.ptr = NULL;
  if (epoll_ctl(fd, EPOLL_CTL_ADD, evfd, &ev) != 0) {
    if (errno != EINVAL) {
      if (!logged_why_not) {
        printf(
            "epoll_ctl with EPOLLEXCLUSIVE | EPOLLONESHOT failed with error: "
            "%d. Not using epollex polling engine.",
            errno);
        logged_why_not = true;
      }
      close(fd);
      close(evfd);
      return false;
    }
  } else {
    if (!logged_why_not) {
      printf(
              "epoll_ctl with EPOLLEXCLUSIVE | EPOLLONESHOT succeeded. This is "
              "evidence of no EPOLLEXCLUSIVE support. Not using "
              "epollex polling engine.");
      logged_why_not = true;
    }
    close(fd);
    close(evfd);
    return false;
  }
  close(evfd);
  close(fd);
  return true;
}

int main() {
    if (grpc_is_epollexclusive_available()) {
        printf("True: epollexclusive is available\n");
        return 0;
    } else {
        printf("False: epollexclusive is NOT available\n");
        return 1;
    }
}

Compile: gcc -static-libstdc++ -std=c++11 epoll_chk.cc -o epollexclusive

Copy link
Contributor

@LinuxGit LinuxGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add epollexclusive source code.

REST LGTM

@@ -0,0 +1,100 @@
i/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the i?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo, changed

Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@liubo0127 liubo0127 merged commit d560c6d into pingcap:master Jan 18, 2019
@liubo0127 liubo0127 deleted the liubo/system-version branch February 19, 2019 10:12
liubo0127 added a commit that referenced this pull request Apr 8, 2019
* Update OS version requirements (#663)

* Update OS version requirements

* Update operating system limits

* Update operating system limits

* Update operating system limits

* Set rolling update limits

* Liubo/check os version (#726)

* Fix OS check

* Fix OS check

* fix yaml format
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants