Skip to content

Conversation

@tangenta
Copy link
Contributor

Cherry-pick #777 to release-3.0.
#777 is rewritten to fit the codebase.

@codecov
Copy link

codecov bot commented Apr 28, 2020

Codecov Report

Merging #838 into release-3.0 will increase coverage by 0.26%.
The diff coverage is 94.91%.

@@               Coverage Diff               @@
##           release-3.0     #838      +/-   ##
===============================================
+ Coverage        64.36%   64.62%   +0.26%     
===============================================
  Files               31       31              
  Lines            11019    11056      +37     
===============================================
+ Hits              7092     7145      +53     
+ Misses            3518     3502      -16     
  Partials           409      409              

Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added the status/LGT1 LGT1 label Apr 28, 2020
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133
Copy link
Member

bb7133 commented Apr 28, 2020

Failed integration case:

7206 ----------------------------------------------------------------------^M
7207 FAIL: builtin_time_test.go:1143: testEvaluatorSuite.TestFromUnixTime^M  
7208 ^M
7209 builtin_time_test.go:1190:^M
7210     c.Assert(ans.String(), Equals, t.expect, Commentf("%+v", t))^M
7211 ... obtained string = "2016-01-01 00:00:00"^M
7212 ... expected string = "2016-01-01 08:00:00"^M
7213 ... {isDecimal:false integralPart:1451606400 fractionalPart:0 decimal:0 format: expect:2016-01-01 08:00:00}^M                                                                                                                                                                7214 ^M
7215 ^M      

We believe that it is not related to this PR, so ignore it.

@bb7133 bb7133 merged commit 7e52571 into pingcap:release-3.0 Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants