Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: add show table regions syntax #349

Merged
merged 7 commits into from
Jul 2, 2019
Merged

*: add show table regions syntax #349

merged 7 commits into from
Jul 2, 2019

Conversation

crazycs520
Copy link
Contributor

@crazycs520 crazycs520 commented Jun 10, 2019 •
edited
Loading

What problem does this PR solve?

Add sql syntax to check split table region status.

SHOW TABLE [table_name] REGIONS

SHOW TABLE [table_name] INDEX [index_name] REGIONS;

What is changed and how it works?

eg

tidb > create table t (a int, b int, index idx(a));
Query OK, 0 rows affected
Time: 0.077s
tidb > split table t between (0) and (10000000000000000) regions 10;
Query OK, 0 rows affected
Time: 0.046s
tidb > split table t index idx between (0) and (1000000000) regions 4;
Query OK, 0 rows affected
Time: 0.408s
tidb> show table t regions;
+-----------+---------------------------------------+---------------------------------------+-----------+---------------------+------------+
| REGION_ID | START_KEY                             | END_Key                               | LEADER_ID | PEERS               | SCATTERING |
+-----------+---------------------------------------+---------------------------------------+-----------+---------------------+------------+
| 23273     | t_6068_i_1_03800000002cb4178003000000 | t_6068_r_1000000000000000             | 23276     | 23274, 23275, 23276 | 0          |
| 23277     | t_6068_r_1000000000000000             | t_6068_r_2000000000000000             | 23280     | 23280, 23281, 23282 | 0          |
| 23283     | t_6068_r_2000000000000000             | t_6068_r_3000000000000000             | 23284     | 23284, 23285, 23287 | 0          |
| 23288     | t_6068_r_3000000000000000             | t_6068_r_4000000000000000             | 23291     | 23290, 23291, 23292 | 0          |
| 23293     | t_6068_r_4000000000000000             | t_6068_r_5000000000000000             | 23297     | 23294, 23297, 23298 | 0          |
| 23299     | t_6068_r_5000000000000000             | t_6068_r_6000000000000000             | 23301     | 23300, 23301, 23302 | 0          |
| 23303     | t_6068_r_6000000000000000             | t_6068_r_7000000000000000             | 23307     | 23306, 23307, 23308 | 0          |
| 23309     | t_6068_r_7000000000000000             | t_6068_r_8000000000000000             | 23313     | 23310, 23311, 23313 | 0          |
| 23314     | t_6068_r_8000000000000000             | t_6068_r_9000000000000000             | 23318     | 23316, 23317, 23318 | 0          |
| 22571     | t_6068_r_9000000000000000             |                                       | 22573     | 22572, 22573, 22575 | 0          |
| 23325     | t_6068_i_1_                           | t_6068_i_1_03800000000ee6b28003000000 | 23328     | 23326, 23327, 23328 | 0          |
| 23329     | t_6068_i_1_03800000000ee6b28003000000 | t_6068_i_1_03800000001dcd650003000000 | 23332     | 23332, 23333, 23334 | 0          |
| 23335     | t_6068_i_1_03800000001dcd650003000000 | t_6068_i_1_03800000002cb4178003000000 | 23339     | 23336, 23337, 23339 | 0          |
+-----------+---------------------------------------+---------------------------------------+-----------+---------------------+------------+
13 rows in set
Time: 0.013s
tidb> show table t index idx regions;
+-----------+---------------------------------------+---------------------------------------+-----------+---------------------+------------+
| REGION_ID | START_KEY                             | END_Key                               | LEADER_ID | PEERS               | SCATTERING |
+-----------+---------------------------------------+---------------------------------------+-----------+---------------------+------------+
| 23325     | t_6068_i_1_                           | t_6068_i_1_03800000000ee6b28003000000 | 23328     | 23326, 23327, 23328 | 0          |
| 23329     | t_6068_i_1_03800000000ee6b28003000000 | t_6068_i_1_03800000001dcd650003000000 | 23332     | 23332, 23333, 23334 | 0          |
| 23335     | t_6068_i_1_03800000001dcd650003000000 | t_6068_i_1_03800000002cb4178003000000 | 23339     | 23336, 23337, 23339 | 0          |
| 23273     | t_6068_i_1_03800000002cb4178003000000 | t_6068_r_1000000000000000             | 23276     | 23274, 23275, 23276 | 0          |
+-----------+---------------------------------------+---------------------------------------+-----------+---------------------+------------+

Check List

Tests

  • Unit test

Code changes

@crazycs520 crazycs520 mentioned this pull request Jun 10, 2019
Merged
@codecov

This comment has been minimized.

Sign in to view
@crazycs520 crazycs520 changed the title *: add split table status syntax *: add show table regions syntax Jun 11, 2019
kennytm
kennytm reviewed Jun 11, 2019
View reviewed changes
Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

parser.y Outdated Show resolved Hide resolved
parser.y Outdated Show resolved Hide resolved
winkyao
winkyao reviewed Jun 13, 2019
View reviewed changes
parser.y
| "SHOW" "TABLE" TableName "REGIONS"
{
$$ = &ast.ShowStmt{
Tp: ast.ShowRegions,
Copy link
Contributor

@winkyao winkyao Jun 13, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please adjust the indent.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

winkyao
winkyao reviewed Jun 13, 2019
View reviewed changes
Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

bb7133
bb7133 reviewed Jun 13, 2019
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm
Copy link
Contributor

kennytm commented Jun 13, 2019

Needs to fix parser.go conflict again 🤷

@tiancaiamao
Copy link
Collaborator

LGTM
Please address conflicts @crazycs520

@tiancaiamao tiancaiamao merged commit f9dfedc into pingcap:master Jul 2, 2019
crazycs520 added a commit to crazycs520/parser that referenced this pull request Jul 12, 2019
@crazycs520
*: add show table regions syntax (pingcap#349)
6bf3fd9 
'SHOW TABLE table_name [INDEX] [index_name] REGIONS'
@crazycs520 crazycs520 mentioned this pull request Jul 12, 2019
Merged
crazycs520 added a commit to crazycs520/parser that referenced this pull request Jul 12, 2019
@crazycs520
*: add show table regions syntax (pingcap#349)
ec8b090
@crazycs520 crazycs520 mentioned this pull request Jul 12, 2019
Merged
bb7133 pushed a commit that referenced this pull request Jul 12, 2019
@crazycs520 @bb7133
*: add show table regions syntax (#349) (#384)
c3bdffe
crazycs520 added a commit that referenced this pull request Jul 15, 2019
@crazycs520
*: add show table regions syntax (#349) (#385)
98d0068
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
@crazycs520 @tiancaiamao
*: add show table regions syntax (pingcap#349)
848f36a 
'SHOW TABLE table_name [INDEX] [index_name] REGIONS'
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
@crazycs520 @tiancaiamao
*: add show table regions syntax (pingcap#349)
48f4043 
'SHOW TABLE table_name [INDEX] [index_name] REGIONS'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennytm kennytm kennytm left review comments

@bb7133 bb7133 bb7133 left review comments

@winkyao winkyao winkyao left review comments

@tiancaiamao tiancaiamao tiancaiamao approved these changes

Assignees
No one assigned
Labels
status/LGT2 LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crazycs520 @kennytm @tiancaiamao @bb7133 @winkyao