fix key work node_id && node_state #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennytm
changed the title
|
PTAL @zimulala |
kennytm
changed the title
lonng
reviewed
Mar 27, 2019
kennytm
reviewed
Mar 27, 2019
| @@ -267,7 +265,7 @@ import ( | |||
| zerofill "ZEROFILL" | |||
| natural "NATURAL" | |||
|
|
|||
| /* The following tokens belong to UnReservedKeyword. */ | |||
| /* The following tokens belong to UnReservedKeyword. Notice: make sure these tokens are contained in UnReservedKeyword. */ | |||
There was a problem hiding this comment.
🤔 So turns out this is already checked in consistent_test.go
There was a problem hiding this comment.
🤔but it don't take effect when 'node_id' not in keyword list, I don't know why
There was a problem hiding this comment.
Only put node_id in TiDBKeyword part (or other special parts) can take effect.
zimulala
reviewed
Mar 27, 2019
|
LGTM |
tiancaiamao
approved these changes
Mar 27, 2019
tiancaiamao
approved these changes
Mar 27, 2019
This was referenced Mar 27, 2019
tiancaiamao
pushed a commit
to tiancaiamao/parser
that referenced
this pull request
Apr 27, 2021
lyonzhi
pushed a commit
to lyonzhi/parser
that referenced
this pull request
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fix issue pingcap/tidb#9910
treat
node_idandnode_statsas key workWhat is changed and how it works?
move
pumpdrainernode_idnode_statstoNotKeywordTokenCheck List
Tests
pumpdrainernode_idnode_statsas column name)Related changes