Set Collate in types.FieldType#1310
Closed
milkice233 wants to merge 1 commit intopingcap:masterfrom
milkice233:master
Closed
Set Collate in types.FieldType#1310milkice233 wants to merge 1 commit intopingcap:masterfrom milkice233:master
milkice233 wants to merge 1 commit intopingcap:masterfrom
milkice233:master
Conversation
Member
|
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve? #1309
What is changed and how it works?
When there is TableOptionCollate present in Options, the StrValue will be added to Collate in types.FieldType
Check List
Tests
Code changes
None
Side effects