Fix Format syntax err message when value out of range #1225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Why are all integration tests timeout? |
xiongjiwei
reviewed
May 18, 2021
| @@ -158,7 +158,24 @@ func (parser *Parser) Parse(sql, charset, collation string) (stmt []ast.StmtNode | |||
| warns = nil | |||
| } | |||
| if len(errs) != 0 { | |||
| return nil, warns, errors.Trace(errs[0]) | |||
| err := errs[0] | |||
There was a problem hiding this comment.
It changes the logistic, can you please explain why do not return the error in some situations?
There was a problem hiding this comment.
Maybe it's not the best solution, I'll close it.
|
BTW, can you please add some tests for it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
related PR: pingcap/tidb#17489 pingcap/tidb#17745
What is changed and how it works?
Ignore error that the decimal out of range the value
Check List
Tests
Code changes
Side effects
Related changes