fix(dashboard): sanitize empty spaces and invalid filter params#3090
Open
1genierock wants to merge 3 commits into
Open
fix(dashboard): sanitize empty spaces and invalid filter params#30901genierock wants to merge 3 commits into
1genierock wants to merge 3 commits into
Conversation
Sanitize params before using them in remote data calls.
|
@1genierock is attempting to deploy a commit to the pingcap Team on Vercel. A member of the Team first needs to authorize it. |
Refactor parameter sanitization logic to use a for-in loop for improved clarity and control over null and undefined values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses an issue where empty space filters or invalid blank parameters passed to the dashboard component trigger faulty state logic or bad remote API requests.
Changes
paramsobject in theAnalyzecomponent properties.sanitizedParamsfilter usingObject.fromEntriesto completely strip out any keys containing empty strings or whitespace-only inputs.useRemoteDatahooks to consumesanitizedParamsinstead of raw parameters.