-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade zap and fix url #18
Conversation
dragonly
commented
Aug 18, 2021
- upgrade zap to 1.19.0
- fix unified log format doc url
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your pull request @dragonly ! May I ask the reason you do the version bump?
@tisonkun I am currently trying to optimize the general_log performance of tidb-server, and digged into some details of For example, in
And buffering is crucial for high performance logging like the general log feature. I haven't done a thorough research, but I believe we can do something later to enhance the logging performance of TiDB itself, by leveraging the enhancements of new releases of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your explanation. LGTM.
Though we're using our own WriteSyncer IIRC, we cannot make use of zapcore.BufferedWriteSyncer
for free.
Actually we can wrap this in a And there are actually several different loggers in TiDB, and I can leverage |