Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove calling close() if zap.Open returns error #11

Merged
merged 1 commit into from
Aug 28, 2020
Merged

remove calling close() if zap.Open returns error #11

merged 1 commit into from
Aug 28, 2020

Conversation

kzh125
Copy link
Contributor

@kzh125 kzh125 commented Aug 26, 2020

if zap.Open returns error, close will be nil, close() will panic

@lance6716
Copy link

LGTM

@lance6716 lance6716 requested a review from nolouch August 26, 2020 08:13
csuzhangxc
csuzhangxc approved these changes Aug 26, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lance6716 lance6716 merged commit fce0951 into pingcap:master Aug 28, 2020
@kzh125 kzh125 deleted the remove_close branch August 28, 2020 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csuzhangxc csuzhangxc csuzhangxc approved these changes

@nolouch nolouch Awaiting requested review from nolouch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kzh125 @lance6716 @csuzhangxc