resource_usage_agent: add RocksDB block read count to Top SQL resource dimensions - #1498
Conversation
Signed-off-by: jiong-nba <jiongnba@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR extends the resource usage metering protobuf schema to allow TiKV to report foreground RocksDB block read counts as part of group-tag resource metering records.
Changes:
- Added a new
rocksdb_block_read_countfield toGroupTagRecordIteminresource_usage_agent.proto(field number9,uint64). - Updated the generated Go bindings to include the new field, plus marshal/size/unmarshal support.
- Updated
scripts/proto.lockto reflect the schema change.
Reviewed changes
Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| scripts/proto.lock | Updates the locked proto schema metadata to include the new field in GroupTagRecordItem. |
| proto/resource_usage_agent.proto | Adds rocksdb_block_read_count to GroupTagRecordItem with tag 9. |
| pkg/resource_usage_agent/resource_usage_agent.pb.go | Regenerates Go protobuf code to include the new field and its serialization logic. |
Files not reviewed (1)
- pkg/resource_usage_agent/resource_usage_agent.pb.go: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: jiong-nba <jiongnba@gmail.com>
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThe resource usage protobuf adds ChangesResource usage reporting
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related issues
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
fb4b0fd to
db3cf69
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
/retest |
1 similar comment
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nolouch, XuHuaiyu, yibin87 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What
Add the rocksdb_block_read_count field to GroupTagRecordItem so TiKV can report foreground RocksDB block reads through resource metering.
Issue Number: ref #1507
Ref: tikv/tikv#19867
Validation
Summary by CodeRabbit