fix

pingcap · Nov 5, 2021 · 47a8ae6 · 47a8ae6
1 parent 68f3bca
commit 47a8ae6
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/v4/export/dump.go b/v4/export/dump.go
@@ -1045,7 +1045,7 @@ func openSQLDB(d *Dumper) error {
 // detectServerInfo is an initialization step of Dumper.
 func detectServerInfo(d *Dumper) error {
 	db, conf := d.dbHandle, d.conf
-	versionStr, err := SelectVersion(db)
+	versionStr, err := SelectVersion(d.tctx, db)
 	if err != nil {
 		conf.ServerInfo = ServerInfoUnknown
 		return err

diff --git a/v4/export/sql.go b/v4/export/sql.go
@@ -279,7 +279,7 @@ func ListAllDatabasesTables(tctx *tcontext.Context, db *sql.Conn, databaseNames
 }
 
 // SelectVersion gets the version information from the database server
-func SelectVersion(ctx tcontext.Context, db *sql.DB) (string, error) {
+func SelectVersion(ctx *tcontext.Context, db *sql.DB) (string, error) {
 	var versionInfo string
 	const queryTiDB = "SELECT tidb_version();"
 	tidbRow := db.QueryRowContext(ctx, queryTiDB)

diff --git a/v4/export/sql_test.go b/v4/export/sql_test.go
@@ -81,7 +81,7 @@ func TestDetectServerInfo(t *testing.T) {
 			mock.ExpectQuery("SELECT version\\(\\);").WillReturnRows(rows)
 		}
 
-		verStr, err := SelectVersion(*tcontext.Background(), db)
+		verStr, err := SelectVersion(tcontext.Background(), db)
 		require.NoError(t, err, comment)
 
 		info := ParseServerInfo(tcontext.Background(), verStr)