-
Notifications
You must be signed in to change notification settings - Fork 688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cloud: add SQL and TiFlash related docs (#9001) #9479
cloud: add SQL and TiFlash related docs (#9001) #9479
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that many notes about a section or variable not applicable to TiDB Cloud exist, and I'm wondering whether we can enclosing that section for TiDB, to avoid using those notes for TiDB Cloud users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 4e1b25e
|
/remove-status LGT1 |
/merge |
/merge |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created: #9674. |
In response to a cherrypick label: new pull request created: #9859. |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
* correct-the-title-level Updated the title level of "Concentrated reads or writes" from the 2nd to the 3rd. * Revert "correct-the-title-level" This reverts commit c879598. * TiUP: Fix broken links and errors * Revert "TiUP: Fix broken links and errors" This reverts commit b0db8e6. * Update dm-release-notes.md * Revert "Update dm-release-notes.md" This reverts commit 1744d50. * This is an automated cherry-pick of #9479 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> * This is an automated cherry-pick of #9479 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> * Update TOC-tidb-cloud.md * update_cloud_docs_to_latest * Update TOC-tidb-cloud.md * Update TOC-tidb-cloud.md * update_links * Update TOC-tidb-cloud.md * Update TOC-tidb-cloud.md * add_custom_content * update_links_temporarily * fix lint errors Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Co-authored-by: qiancai <“qqzczy@126.com”> Co-authored-by: qiancai <qqzczy@126.com>
…pingcap#9859) * correct-the-title-level Updated the title level of "Concentrated reads or writes" from the 2nd to the 3rd. * Revert "correct-the-title-level" This reverts commit c879598. * TiUP: Fix broken links and errors * Revert "TiUP: Fix broken links and errors" This reverts commit b0db8e6. * Update dm-release-notes.md * Revert "Update dm-release-notes.md" This reverts commit 1744d50. * This is an automated cherry-pick of pingcap#9479 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> * This is an automated cherry-pick of pingcap#9479 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> * Update TOC-tidb-cloud.md * update_cloud_docs_to_latest * Update TOC-tidb-cloud.md * Update TOC-tidb-cloud.md * update_links * Update TOC-tidb-cloud.md * Update TOC-tidb-cloud.md * add_custom_content * update_links_temporarily * fix lint errors Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Co-authored-by: qiancai <“qqzczy@126.com”> Co-authored-by: qiancai <qqzczy@126.com>
This is an automated cherry-pick of #9001
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?