dm: add a dm directory #873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
IANTHEREAL
commented
Jan 26, 2019
•
IANTHEREAL
commented
- use AP for link in markdown
- add dm directory in tools
- remove upgrade from syncer/loader
lilin90
reviewed
Jan 26, 2019
| @@ -40,7 +40,7 @@ This sections describes the considerations that you need to know when you restar | |||
|
|
|||
| **In the process of full data loading:** | |||
|
|
|||
| For the SQL files during full data import, DM uses the downstream database to record the checkpoint information. When DM-worker is restarted, it checks the checkpoint information and you can use the [`start-task` command](../tools/data-migration-practice.md#step-4-start-the-data-synchronization-task) to recover the data synchronization task automatically. | |||
| For the SQL files during full data import, DM uses the downstream database to record the checkpoint information. When DM-worker is restarted, it checks the checkpoint information and you can use the [`start-task` command](/tools/dm/practice.md#step-4-start-the-data-synchronization-task) to recover the data synchronization task automatically. | |||
There was a problem hiding this comment.
Suggested change
| For the SQL files during full data import, DM uses the downstream database to record the checkpoint information. When DM-worker is restarted, it checks the checkpoint information and you can use the [`start-task` command](/tools/dm/practice.md#step-4-start-the-data-synchronization-task) to recover the data synchronization task automatically. | |
| For the SQL files during full data import, DM uses the downstream database to record the checkpoint information. When DM-worker is restarted, it checks the checkpoint information and you can use the [`start-task` command](../../tools/dm/practice.md#step-4-start-the-data-synchronization-task) to recover the data synchronization task automatically. |
There was a problem hiding this comment.
Any relative path that links to another file must start from the level of the root directory. Otherwise, your link will be a broken link at the PingCAP website.
Please update all related links involved in this PR. :)
There was a problem hiding this comment.
I don't use relative path, I use absolute path, can we refine the script for PingCAP website? /tools is more reasonable than ../../tools
There was a problem hiding this comment.
@GregoryIan I checked with @xuechunL. We do support the type of links in this PR. So you can just keep them. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.