-
Notifications
You must be signed in to change notification settings - Fork 688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: update DM TOC and refine content #869
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest LGTM
README.md
Outdated
- [Deploy](tools/data-migration-deployment.md) | ||
- [Synchronize Data](tools/data-migration-practice.md) | ||
- [Synchronize](tools/data-migration-practice.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a more meaningful name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@csuzhangxc Do you have any suggestions on this? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Get Started? 😂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha~ Thanks for your suggestion, but I think it might be a little bit weird to use "Get Started" in this position. @GregoryIan What's your opinion and suggestion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's a step by step instructions using dm-ansible. it should belong to Get Started
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this file contains deoployment and how to synchroniza data, Get Started
may be better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to add a step by step instrucation that contains deploy dm manually and create a simple task, like this file do
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GregoryIan Perhaps just leave a Deploy
in the TOC that points to the tools/data-migration-practice.md
file? That file about deploying the DM cluster using DM-Ansible is also mentioned in this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about
[get started](tools/data-migration-practice.md)
Deploy
- [ansible](tools/data-migration-deployment.md)
- [binary](xxxxx)
What I can confirm is that we have to need a get started
. If the content of tools/data-migration-practice.md
is not a good enough, we can modify it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
@GregoryIan @csuzhangxc @CaitinChen PTAL