Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update DM TOC and refine content #869

Merged
merged 2 commits into from
Jan 28, 2019

Conversation

lilin90
Copy link
Member

@lilin90 lilin90 commented Jan 24, 2019

@GregoryIan @csuzhangxc @CaitinChen PTAL

csuzhangxc
csuzhangxc previously approved these changes Jan 25, 2019
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

README.md Outdated
- [Deploy](tools/data-migration-deployment.md)
- [Synchronize Data](tools/data-migration-practice.md)
- [Synchronize](tools/data-migration-practice.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a more meaningful name?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@csuzhangxc Do you have any suggestions on this? :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get Started? 😂

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha~ Thanks for your suggestion, but I think it might be a little bit weird to use "Get Started" in this position. @GregoryIan What's your opinion and suggestion?

Copy link
Contributor

@IANTHEREAL IANTHEREAL Jan 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a step by step instructions using dm-ansible. it should belong to Get Started

Copy link
Contributor

@IANTHEREAL IANTHEREAL Jan 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this file contains deoployment and how to synchroniza data, Get Started may be better

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to add a step by step instrucation that contains deploy dm manually and create a simple task, like this file do

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GregoryIan Perhaps just leave a Deploy in the TOC that points to the tools/data-migration-practice.md file? That file about deploying the DM cluster using DM-Ansible is also mentioned in this file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about

[get started](tools/data-migration-practice.md)
Deploy
- [ansible](tools/data-migration-deployment.md)
- [binary](xxxxx)

What I can confirm is that we have to need a get started. If the content of tools/data-migration-practice.md is not a good enough, we can modify it.

@csuzhangxc csuzhangxc dismissed their stale review January 25, 2019 08:27

dismiss misoperation

@lilin90 lilin90 mentioned this pull request Jan 27, 2019
8 tasks
Copy link
Contributor

@CaitinChen CaitinChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IANTHEREAL
Copy link
Contributor

LGTM

@lilin90 lilin90 merged commit 6ce29b4 into pingcap:master Jan 28, 2019
@lilin90 lilin90 deleted the dm-toc-update branch January 28, 2019 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants