Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add TiDB 2.1 Upgrade Guide #780

Merged
merged 7 commits into from
Dec 18, 2018
Merged

*: add TiDB 2.1 Upgrade Guide #780

merged 7 commits into from
Dec 18, 2018

Conversation

lilin90
Copy link
Member

@lilin90 lilin90 commented Nov 28, 2018


This document describes how to upgrade from TiDB 2.0 (TiDB 2.0.1 or later) or TiDB 2.1 RC version to TiDB 2.1 GA version. TiDB 2.1 is not compatible with the Kafka version of TiDB-Binlog. If your current TiDB cluster has already been using the [Kafka version of TiDB-Binlog](../tools/tidb-binlog-kafka.md), you need to [upgrade it to the cluster version of TiDB-Binlog](../tools/tidb-binlog-cluster.md#tidb-binlog-upgrade).

## Step 1: Install Ansible and dependencies on the Control Machine
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a description of how to do a rolling update without Ansible?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gregwebs Currently, we only provide the Ansible approach, which is also the recommended one. (I've checked with @liubo0127 )

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we describe in abstract terms what Ansible is doing?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, I see it here, would be good to link there.

op-guide/tidb-v2.1-upgrade-guide.md Outdated Show resolved Hide resolved
op-guide/tidb-v2.1-upgrade-guide.md Outdated Show resolved Hide resolved
op-guide/tidb-v2.1-upgrade-guide.md Outdated Show resolved Hide resolved
Copy link
Contributor

@CaitinChen CaitinChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90
Copy link
Member Author

lilin90 commented Nov 29, 2018

@kennytm @liubo0127 PTAL

Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My suggestions on op-guide/tidb-v2.1-upgrade-guide.md are still not resolved.

Rest LGTM.

tools/tidb-binlog-cluster.md Outdated Show resolved Hide resolved
tools/tidb-binlog-cluster.md Outdated Show resolved Hide resolved
tools/tidb-binlog-cluster.md Outdated Show resolved Hide resolved
@lilin90
Copy link
Member Author

lilin90 commented Nov 30, 2018

@kennytm Thanks! I checked op-guide/tidb-v2.1-upgrade-guide.md, and I think that your previous comments were resolved :) Now new comments addressed.

@lilin90
Copy link
Member Author

lilin90 commented Nov 30, 2018

@gregwebs Comment addressed. Thanks!

@QueenyJin
Copy link
Contributor

Please hold on merging this Pull Request. More updates are coming

@lilin90 lilin90 merged commit c47434f into pingcap:master Dec 18, 2018
@lilin90 lilin90 deleted the 2.1-upgrade branch March 25, 2020 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants