Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2dc: add config descriptions #7796

Merged
merged 2 commits into from
Mar 9, 2022
Merged

2dc: add config descriptions #7796

merged 2 commits into from
Mar 9, 2022

Conversation

en-jin19
Copy link
Contributor

@en-jin19 en-jin19 commented Mar 9, 2022

What is changed, added or deleted? (Required)

Add descriptions about using configurations in rule.json.

Note: the change in "releases/release-3.0.3.md" is made to fix a Jenkins error, and this error only occurred in the Chinese doc. So this English PR did not fix that problem.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.0 (TiDB 6.0 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@en-jin19 en-jin19 added type/enhancement The issue or PR belongs to an enhancement. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. area/scheduling Indicates that the Issue or PR belongs to the area of scheduling. needs-cherry-pick-release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. labels Mar 9, 2022
@en-jin19 en-jin19 requested review from disksing and TomShawn March 9, 2022 03:45
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 9, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 9, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 9, 2022
@TomShawn
Copy link
Contributor

TomShawn commented Mar 9, 2022

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 9, 2022
@TomShawn
Copy link
Contributor

TomShawn commented Mar 9, 2022

/verify

@en-jin19
Copy link
Contributor Author

en-jin19 commented Mar 9, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9712ddd

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 9, 2022
@ti-chi-bot ti-chi-bot merged commit d41cd90 into pingcap:master Mar 9, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 9, 2022
Merged
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7797.

@ti-chi-bot ti-chi-bot mentioned this pull request Mar 9, 2022
Merged
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7798.

ti-chi-bot added a commit that referenced this pull request Mar 9, 2022
@ti-chi-bot
2dc: add config descriptions (#7796) (#7798)
385fc21
ti-chi-bot added a commit that referenced this pull request Mar 9, 2022
@ti-chi-bot
2dc: add config descriptions (#7796) (#7797)
183f75f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

@disksing disksing disksing approved these changes

Assignees
No one assigned
Labels
area/scheduling Indicates that the Issue or PR belongs to the area of scheduling. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@en-jin19 @ti-chi-bot @TomShawn @disksing