-
Notifications
You must be signed in to change notification settings - Fork 688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add use casdoor as example to login dashboard by sso #7510
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Welcome @Steve0x2a! |
@Steve0x2a Unless a PR fixes a critical bug, we do not recommend PR cherry-pick to too many earlier versions. PTAL and choose the appropriate versions. Thanks. |
@shichun-0415 OK, I made my choice based on previous relevant pr. What do you think about choosing master and v5.4? Or just master? |
@Steve0x2a I think master and v5.4 are fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the contribution! This is very cool!
Co-authored-by: Wenxuan <hi@breeswish.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com>
Hi @shichun-0415 @breeswish any update on this PR? |
Sorry for late reply. |
Signed-off-by: 0x2a <stevesough@gmail.com>
@shichun-0415 I have added a picture, and https://casdoor.org/ is our documentation and introduction site, you can see the page I mentioned in the demo site |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 6cec629
|
In response to a cherrypick label: new pull request created: #7649. |
First-time contributors' checklist
What is changed, added or deleted? (Required)
Add use casdoor as example to login dashboard by sso
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?