Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add use casdoor as example to login dashboard by sso #7510

Merged
merged 4 commits into from
Feb 18, 2022

Conversation

Steve0x2a
Copy link
Contributor

@Steve0x2a Steve0x2a commented Feb 7, 2022

First-time contributors' checklist

What is changed, added or deleted? (Required)

Add use casdoor as example to login dashboard by sso

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 7, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • breeswish
  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. labels Feb 7, 2022
@ti-chi-bot ti-chi-bot added the missing-translation-status This PR does not have translation status info. label Feb 7, 2022
@ti-chi-bot
Copy link
Member

Welcome @Steve0x2a!

It looks like this is your first PR to pingcap/docs 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/docs. 😃

@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 7, 2022
@shichun-0415 shichun-0415 added area/diagnosis Indicates that the Issue or PR belongs to the area of diagnosis and monitoring. translation/doing This PR's assignee is translating this PR. type/enhancement The issue or PR belongs to an enhancement. and removed missing-translation-status This PR does not have translation status info. labels Feb 7, 2022
@shichun-0415 shichun-0415 self-assigned this Feb 7, 2022
@shichun-0415
Copy link
Contributor

@Steve0x2a Unless a PR fixes a critical bug, we do not recommend PR cherry-pick to too many earlier versions. PTAL and choose the appropriate versions. Thanks.

@Steve0x2a
Copy link
Contributor Author

@shichun-0415 OK, I made my choice based on previous relevant pr. What do you think about choosing master and v5.4? Or just master?

@shichun-0415
Copy link
Contributor

@Steve0x2a I think master and v5.4 are fine.

@shichun-0415 shichun-0415 requested review from shichun-0415 and removed request for TomShawn February 7, 2022 06:38
Copy link
Member

@breezewish breezewish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the contribution! This is very cool!

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 7, 2022
Co-authored-by: Wenxuan <hi@breeswish.org>
Copy link
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

dashboard/dashboard-session-sso.md Outdated Show resolved Hide resolved
dashboard/dashboard-session-sso.md Outdated Show resolved Hide resolved
dashboard/dashboard-session-sso.md Outdated Show resolved Hide resolved
dashboard/dashboard-session-sso.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 7, 2022
Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com>
@shichun-0415 shichun-0415 added the needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. label Feb 11, 2022
@hsluoyz
Copy link

hsluoyz commented Feb 17, 2022

Hi @shichun-0415 @breeswish any update on this PR?

@shichun-0415
Copy link
Contributor

shichun-0415 commented Feb 18, 2022

Hi @shichun-0415 @breeswish any update on this PR?

Sorry for late reply.
For this description (figure below), could you please add an image? I have visited https://casdoor.org/ but cannot find the portal for administration site, neither the buttons you have mentioned.
image

Signed-off-by: 0x2a <stevesough@gmail.com>
@Steve0x2a
Copy link
Contributor Author

@shichun-0415 I have added a picture, and https://casdoor.org/ is our documentation and introduction site, you can see the page I mentioned in the demo site

@shichun-0415
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6cec629

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 18, 2022
@ti-chi-bot ti-chi-bot merged commit 4c3ecb1 into pingcap:master Feb 18, 2022
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7649.

@TomShawn TomShawn assigned Steve0x2a and unassigned shichun-0415 Feb 21, 2022
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/diagnosis Indicates that the Issue or PR belongs to the area of diagnosis and monitoring. contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants