sql: improve privileges docs #695
Conversation
|
PTAL @tiancaiamao |
sql/privilege.md
Outdated
| @@ -289,7 +294,7 @@ When TiDB starts, some privilege-check tables are loaded into memory, and then t | |||
| If an immediate effect is needed when you modify the `grant` table, you can run the following command: | |||
|
|
|||
| ```sql | |||
| flush privileges | |||
| flush privileges; | |||
There was a problem hiding this comment.
@lilin90 do we have a style for SQL commands? I like to write keywords in caps as kenny suggests, but many of our existing examples are lower case.
There was a problem hiding this comment.
If the style is all-lowercase then the DROP USER 'test'; statement above should be changed to drop user 'test';.
There was a problem hiding this comment.
Yeah, I agree. I'll change it.
There was a problem hiding this comment.
@lilin90 There are quite a few inconsistencies: CREATE USER, REVOKE are in caps. I can go through and change once I have confirmation of the style.
There was a problem hiding this comment.
@morgo Thanks! Currently, we don't have a strict SQL style. But to improve the consistency, we can now establish one: "Capitalize all SQL keywords and reserved words." Later, I'll update that in docs-cn and tell other members to follow this style.
There was a problem hiding this comment.
@lilin90 thanks, I've updated all keywords to caps. PTAL
|
LGTM |
I noticed a few small errors in the privileges page. While few users use column-level privileges, I think it is still worth calling out on the compatibility page.