Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br: update documents for br scenario #6673

Merged
merged 2 commits into from
Oct 28, 2021
Merged

br: update documents for br scenario #6673

merged 2 commits into from
Oct 28, 2021

Conversation

Liuxiaozhen12
Copy link
Contributor

First-time contributors' checklist

What is changed, added or deleted? (Required)

Add description for br migration scenario.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Liuxiaozhen12 Liuxiaozhen12 added type/enhancement The issue or PR belongs to an enhancement. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. area/migrate Indicates that the Issue or PR belongs to the area of TiDB migration tools. needs-cherry-pick-release-5.2 labels Oct 27, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 27, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 27, 2021
hfxsd
hfxsd reviewed Oct 27, 2021
View reviewed changes
br/backup-and-restore-tool.md Outdated Show resolved Hide resolved
br/backup-and-restore-tool.md Outdated Show resolved Hide resolved
br/backup-and-restore-tool.md Outdated Show resolved Hide resolved
@hfxsd
Copy link
Collaborator

hfxsd commented Oct 27, 2021

LGTM

@Liuxiaozhen12 @hfxsd
Apply suggestions from code review
ae62b8a 
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
3pointer
3pointer approved these changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@3pointer 3pointer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 27, 2021
@Liuxiaozhen12
Copy link
Contributor Author

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 28, 2021
@Liuxiaozhen12
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ae62b8a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 28, 2021
@ti-chi-bot ti-chi-bot merged commit 360b8c2 into pingcap:master Oct 28, 2021
@Liuxiaozhen12 Liuxiaozhen12 deleted the br_scenario_update branch October 28, 2021 03:01
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 28, 2021
Merged
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6675.

ti-chi-bot added a commit that referenced this pull request Oct 28, 2021
@ti-chi-bot
br: update documents for br scenario (#6673) (#6675)
0027898
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hfxsd hfxsd hfxsd left review comments

@3pointer 3pointer 3pointer approved these changes

Assignees
No one assigned
Labels
area/migrate Indicates that the Issue or PR belongs to the area of TiDB migration tools. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Liuxiaozhen12 @ti-chi-bot @hfxsd @3pointer