Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TLS docs: fix some typo #6655

Merged
merged 3 commits into from
Oct 25, 2021
Merged

TLS docs: fix some typo #6655

merged 3 commits into from
Oct 25, 2021

Conversation

Liuxiaozhen12
Copy link
Contributor

@Liuxiaozhen12 Liuxiaozhen12 commented Oct 21, 2021 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Liuxiaozhen12 Liuxiaozhen12 added type/bugfix This PR fixes a bug. translation/no-need No need to translate this PR. needs-cherry-pick-release-5.2 labels Oct 21, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 21, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 21, 2021
@Liuxiaozhen12 Liuxiaozhen12 marked this pull request as draft October 21, 2021 05:12
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 21, 2021
@Liuxiaozhen12
Copy link
Contributor Author

Maybe add some other minor changes later.

@TomShawn TomShawn mentioned this pull request Oct 21, 2021
Merged
13 tasks
@Liuxiaozhen12 Liuxiaozhen12 marked this pull request as ready for review October 21, 2021 07:18
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 21, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 25, 2021
@TomShawn TomShawn added the require-LGT1 Indicates that the PR requires an LGTM. label Oct 25, 2021
@Liuxiaozhen12
Copy link
Contributor Author

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 25, 2021
@Liuxiaozhen12
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b9ce3fe

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 25, 2021
@Liuxiaozhen12 Liuxiaozhen12 removed the require-LGT1 Indicates that the PR requires an LGTM. label Oct 25, 2021
@ti-chi-bot ti-chi-bot merged commit b80c6e9 into pingcap:master Oct 25, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 25, 2021
Merged
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6667.

ti-chi-bot added a commit that referenced this pull request Oct 25, 2021
@ti-chi-bot
TLS docs: fix some typo (#6655) (#6667)
ab6ab82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

Assignees
No one assigned
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/no-need No need to translate this PR. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Liuxiaozhen12 @ti-chi-bot @TomShawn