Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the default value description for tidb_enforce_mpp #5955

Merged
merged 4 commits into from
Jul 9, 2021
Merged

Add the default value description for tidb_enforce_mpp #5955

merged 4 commits into from
Jul 9, 2021

Conversation

Liuxiaozhen12
Copy link
Contributor

What is changed, added or deleted? (Required)

Add the default value description for the system variable tidb_enforce_mpp

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot requested a review from TomShawn July 8, 2021 08:03
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 8, 2021
@Liuxiaozhen12 Liuxiaozhen12 added needs-cherry-pick-release-5.1 translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Jul 8, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Jul 8, 2021
@Liuxiaozhen12 Liuxiaozhen12 requested a review from LittleFall July 8, 2021 08:05
LittleFall
LittleFall reviewed Jul 8, 2021
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
LittleFall
LittleFall approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@LittleFall LittleFall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

others lgtm

@ti-chi-bot
Copy link
Member

@LittleFall: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

others lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Liuxiaozhen12
Liuxiaozhen12 commented Jul 9, 2021
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
TomShawn
TomShawn reviewed Jul 9, 2021
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
TomShawn
TomShawn reviewed Jul 9, 2021
View reviewed changes
tidb-configuration-file.md Outdated Show resolved Hide resolved
TomShawn
TomShawn reviewed Jul 9, 2021
View reviewed changes
tidb-configuration-file.md Outdated Show resolved Hide resolved
TomShawn
TomShawn approved these changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 9, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Jul 9, 2021

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 9, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Jul 9, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7946531

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 9, 2021
@ti-chi-bot ti-chi-bot merged commit 9577038 into pingcap:master Jul 9, 2021
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5961.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 9, 2021
Merged
11 tasks
ti-chi-bot added a commit that referenced this pull request Jul 9, 2021
@ti-chi-bot
Add the default value description for tidb_enforce_mpp (#5955) (#5961)
2b43641
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

@LittleFall LittleFall LittleFall approved these changes

Assignees
No one assigned
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Liuxiaozhen12 @ti-chi-bot @TomShawn @LittleFall