Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TiKV configuration: update max-peer-down-duration default value #5933

Merged
merged 2 commits into from
Jul 8, 2021
Merged

TiKV configuration: update max-peer-down-duration default value #5933

merged 2 commits into from
Jul 8, 2021

Conversation

Liuxiaozhen12
Copy link
Contributor

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot requested a review from TomShawn July 7, 2021 10:05
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 7, 2021
@Liuxiaozhen12 Liuxiaozhen12 added for-future-release This PR only applies to master for now and might cherry-pick to a future release. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 7, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Jul 7, 2021
@Liuxiaozhen12 Liuxiaozhen12 requested a review from yiwu-arbug July 8, 2021 03:02
TomShawn
TomShawn reviewed Jul 8, 2021
View reviewed changes
tikv-configuration-file.md Outdated Show resolved Hide resolved
@Liuxiaozhen12 @TomShawn
Apply suggestions from code review
2d86d24 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 8, 2021
@Liuxiaozhen12 Liuxiaozhen12 requested a review from TomShawn July 8, 2021 03:06
TomShawn
TomShawn approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 8, 2021
@TomShawn TomShawn added the require-LGT1 Indicates that the PR requires an LGTM. label Jul 8, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Jul 8, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2d86d24

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 8, 2021
@ti-chi-bot ti-chi-bot merged commit 0619ba9 into pingcap:master Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

@yiwu-arbug yiwu-arbug Awaiting requested review from yiwu-arbug

Assignees
No one assigned
Labels
for-future-release This PR only applies to master for now and might cherry-pick to a future release. require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Liuxiaozhen12 @ti-chi-bot @TomShawn