Skip to content

quick-start-with-tidb: add a note to clarify the example ip #5865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 8, 2021
Merged

quick-start-with-tidb: add a note to clarify the example ip #5865

merged 3 commits into from
Jul 8, 2021

Conversation

Liuxiaozhen12
Copy link
Contributor

What is changed, added or deleted? (Required)

Add a note to clarify the example IP in quick-start-with-tidb.md.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot requested a review from TomShawn June 25, 2021 07:21
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 25, 2021
@Liuxiaozhen12
Copy link
Contributor Author

/translation from-docs-cn
/label v5.1
/label needs-cherry-pick-release-5.0
/label needs-cherry-pick-release-4.0

@ti-chi-bot ti-chi-bot added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v5.1 This PR/issue applies to TiDB v5.1. needs-cherry-pick-release-5.0 and removed missing-translation-status This PR does not have translation status info. labels Jun 25, 2021
@Liuxiaozhen12 Liuxiaozhen12 requested a review from lucklove June 25, 2021 07:22
@TomShawn TomShawn removed the v5.1 This PR/issue applies to TiDB v5.1. label Jun 25, 2021
@TomShawn TomShawn changed the title Update quick-start-with-tidb.md quick-start-with-tidb: add a note to clarify the example ip Jul 8, 2021
TomShawn
TomShawn reviewed Jul 8, 2021
View reviewed changes
TomShawn
TomShawn approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 8, 2021
@TomShawn TomShawn added the require-LGT1 Indicates that the PR requires an LGTM. label Jul 8, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Jul 8, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: fc84d76

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 8, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Jul 8, 2021

/rebase

@github-actions github-actions bot force-pushed the clarify-example-ip branch from fc84d76 to 57c7376 Compare July 8, 2021 03:48
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jul 8, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Jul 8, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 57c7376

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 8, 2021
@ti-chi-bot ti-chi-bot merged commit d50e4ce into pingcap:master Jul 8, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 8, 2021
Merged
11 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5940.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5941.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 8, 2021
Merged
11 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5942.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 8, 2021
Merged
11 tasks
ti-chi-bot added a commit that referenced this pull request Jul 8, 2021
@ti-chi-bot
quick-start-with-tidb: add a note to clarify the example ip (#5865) (#…
0cae595 
…5940)
ti-chi-bot added a commit that referenced this pull request Jul 8, 2021
@ti-chi-bot
quick-start-with-tidb: add a note to clarify the example ip (#5865) (#…
346a90f 
…5941)
ti-chi-bot added a commit that referenced this pull request Jul 8, 2021
@ti-chi-bot
quick-start-with-tidb: add a note to clarify the example ip (#5865) (#…
fcb5819 
…5942)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucklove lucklove Awaiting requested review from lucklove

1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Liuxiaozhen12 @ti-chi-bot @TomShawn