Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add v510 benchmark doc #5842

Merged
merged 6 commits into from
Jun 24, 2021
Merged

add v510 benchmark doc #5842

merged 6 commits into from
Jun 24, 2021

Conversation

Joyinqin
Copy link
Contributor

First-time contributors' checklist

What is changed, added or deleted? (Required)

add v510 benchmark doc

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot requested a review from TomShawn June 24, 2021 08:04
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 24, 2021
@Joyinqin Joyinqin added needs-cherry-pick-release-5.1 translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v5.1 This PR/issue applies to TiDB v5.1. labels Jun 24, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Jun 24, 2021
@Joyinqin Joyinqin requested review from qiancai and shuke987 June 24, 2021 08:13
TomShawn
TomShawn reviewed Jun 24, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor comments

benchmark/benchmark-sysbench-v5.1.0-vs-v5.0.2.md Outdated Show resolved Hide resolved
benchmark/benchmark-sysbench-v5.1.0-vs-v5.0.2.md Outdated Show resolved Hide resolved
benchmark/v5.1-performance-benchmarking-with-tpcc.md Outdated Show resolved Hide resolved
benchmark/benchmark-sysbench-v5.1.0-vs-v5.0.2.md Outdated Show resolved Hide resolved
benchmark/v5.1-performance-benchmarking-with-tpcc.md Outdated Show resolved Hide resolved
benchmark/v5.1-performance-benchmarking-with-tpcc.md Outdated Show resolved Hide resolved
Joyinqin and others added 2 commits June 24, 2021 16:19
@Joyinqin @TomShawn
Apply suggestions from code review
ae87382 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@Joyinqin
Update v5.1-performance-benchmarking-with-tpcc.md
66a6708
TomShawn
TomShawn approved these changes Jun 24, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 24, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • qiancai

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 24, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 66a6708

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 24, 2021
@ti-chi-bot ti-chi-bot merged commit 2046b6c into pingcap:master Jun 24, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 24, 2021
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5845.

ti-chi-bot added a commit that referenced this pull request Jun 24, 2021
@ti-chi-bot
add v510 benchmark doc (#5842) (#5845)
0ccfa07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiancai qiancai qiancai approved these changes

@TomShawn TomShawn TomShawn approved these changes

@shuke987 shuke987 Awaiting requested review from shuke987

Assignees
No one assigned
Labels
size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v5.1 This PR/issue applies to TiDB v5.1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Joyinqin @ti-chi-bot @TomShawn @qiancai