Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change pr to issue #5768

Merged
merged 2 commits into from
Jun 10, 2021
Merged

Change pr to issue #5768

merged 2 commits into from
Jun 10, 2021

Conversation

TomShawn
Copy link
Contributor

What is changed, added or deleted? (Required)

Change pr to issue in 5.0.2 release notes

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@TomShawn TomShawn added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-release-5.0 labels Jun 10, 2021
@TomShawn TomShawn requested a review from Joyinqin June 10, 2021 06:12
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 10, 2021
@TomShawn TomShawn added require-LGT1 Indicates that the PR requires an LGTM. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 10, 2021
@Joyinqin
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

@Joyinqin: Please use GitHub review feature instead of /lgtm [cancel] when you want to submit review to the pull request.
For how to use GitHub review feature, see also this document provided by GitHub.

For the reason we drop support to the commands, see also this page.
This reply is being used as a temporary reply during the migration of review process and will be removed on July 1st.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 10, 2021
Joyinqin
Joyinqin approved these changes Jun 10, 2021
View reviewed changes
Copy link
Contributor

@Joyinqin Joyinqin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Joyinqin

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 10, 2021
@TomShawn
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 651559d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 10, 2021
@ti-chi-bot ti-chi-bot merged commit 929d869 into master Jun 10, 2021
@TomShawn TomShawn deleted the TomShawn-patch-2 branch June 10, 2021 08:42
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 10, 2021
Merged
11 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5769.

ti-chi-bot added a commit that referenced this pull request Jun 10, 2021
@ti-chi-bot
Change pr to issue (#5768) (#5769)
1ef99d8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Joyinqin Joyinqin Joyinqin approved these changes

Assignees
No one assigned
Labels
require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TomShawn @Joyinqin @ti-chi-bot