-
Notifications
You must be signed in to change notification settings - Fork 694
system-variables: ensure alphabetical order #5711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 6ea73ee
|
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created: #5714. |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created: #5715. |
/remove-translation doing |
What is changed, added or deleted? (Required)
The system variables are not in alphabetical order. This is useful for users when a list is long because it makes it easier to search for them. I also plan to auto-generate the system-variables page from the server's variables list, but it's not possible to do when the order is non-deterministic.
I have made one other small edit, which is to normalize the introduced version and remove the text " version" when it appears. I will fix the CI if this breaks any anchors.
close part of #3155
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?