Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update TiDB 6MB limit #5676

Merged
merged 9 commits into from
Jun 1, 2021
Merged

update TiDB 6MB limit #5676

merged 9 commits into from
Jun 1, 2021

Conversation

Liuxiaozhen12
Copy link
Contributor

What is changed, added or deleted? (Required)

TiDB introduced txn-entry-size-limit in v5.0 and added it to the doc #5158, but there are some outdated descriptions left.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot requested a review from TomShawn May 20, 2021 08:05
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 20, 2021
@Liuxiaozhen12
Copy link
Contributor Author

/label needs-cherry-pick-release-4.0
/label needs-cherry-pick-release-5.0
/translation from-docs-cn

@ti-chi-bot ti-chi-bot added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-release-4.0 and removed missing-translation-status This PR does not have translation status info. labels May 20, 2021
TomShawn
TomShawn reviewed May 20, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The requires-version-specific-changes label is missing. Please add this label in this PR and read the docs-cn PR description again to see which version needs specific changes. Thanks!

error-codes.md Outdated Show resolved Hide resolved
error-codes.md Outdated Show resolved Hide resolved
faq/migration-tidb-faq.md Outdated Show resolved Hide resolved
storage-engine/titan-overview.md Outdated Show resolved Hide resolved
tidb-limitations.md Outdated Show resolved Hide resolved
Liuxiaozhen12 and others added 2 commits May 21, 2021 10:55
@Liuxiaozhen12 @TomShawn
Apply suggestions from code review
07f5d14 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Apply suggestions from code review
5ec0672
@Liuxiaozhen12
Copy link
Contributor Author

/label requires-version-specific-changes

@ti-chi-bot ti-chi-bot added the requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. label May 21, 2021
@Liuxiaozhen12
Copy link
Contributor Author

/cc @youjiali1995

@ti-chi-bot ti-chi-bot requested a review from youjiali1995 May 24, 2021 06:53
TomShawn
TomShawn approved these changes May 25, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

error-codes.md Outdated Show resolved Hide resolved
faq/migration-tidb-faq.md Outdated Show resolved Hide resolved
storage-engine/titan-overview.md Outdated Show resolved Hide resolved
tidb-limitations.md Outdated Show resolved Hide resolved
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 25, 2021
TomShawn
TomShawn approved these changes Jun 1, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn @youjiali1995
Update storage-engine/titan-overview.md
54edb13 
Co-authored-by: Lei Zhao <zlwgx1023@gmail.com>
@TomShawn
Copy link
Contributor

TomShawn commented Jun 1, 2021

/label require-LGT1

@ti-chi-bot ti-chi-bot added the require-LGT1 Indicates that the PR requires an LGTM. label Jun 1, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Jun 1, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 54edb13

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 1, 2021
@ti-chi-bot ti-chi-bot merged commit 5db25d4 into pingcap:master Jun 1, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 1, 2021
Merged
10 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5737.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 1, 2021
Merged
10 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5738.

ti-chi-bot added a commit that referenced this pull request Jun 1, 2021
@ti-chi-bot
update TiDB 6MB limit (#5676) (#5738)
ee29c72
ti-chi-bot added a commit that referenced this pull request Jun 1, 2021
@ti-chi-bot
update TiDB 6MB limit (#5676) (#5737)
f44cbe6
@Liuxiaozhen12 Liuxiaozhen12 deleted the Liuxiaozhen-patch2 branch June 10, 2021 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youjiali1995 youjiali1995 youjiali1995 left review comments

@TomShawn TomShawn TomShawn approved these changes

Assignees
No one assigned
Labels
require-LGT1 Indicates that the PR requires an LGTM. requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Liuxiaozhen12 @ti-chi-bot @TomShawn @youjiali1995